Creepso/multi-downloader-nx
1
0
Fork 0
Code Issues 38 Pull requests 10 Projects Releases 70 Packages Wiki Activity Actions

Add check for (NC) in parseSelect #738

Open
KasumiDev wants to merge 1 commit from KasumiDev/patch-1 into master
pull from: KasumiDev/patch-1
merge into: Creepso:master
Conversation 0 Commits 1 Files changed 1 +7 -1
KasumiDev commented 2024-07-11 10:25:11 +00:00 (Migrated from github.com)
Copy link

To support selections like 1 (NC) the parser needed a little change.

This will fix #737

Working (Tested):

  • Selection via "List Episodes"
  • Selection via Manual Input like 1 (NC)
  • Range Selection 1 (NC) - 9 (NC)
  • Download

So not everything works as of now but it let's us download those episodes as well

To support selections like `1 (NC)` the parser needed a little change. This will fix #737 Working (Tested): - [ ] Selection via "List Episodes" - [x] Selection via Manual Input like `1 (NC)` - [ ] Range Selection `1 (NC) - 9 (NC)` - [x] Download So not everything works as of now but it let's us download those episodes as well
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin KasumiDev/patch-1:KasumiDev/patch-1
git checkout KasumiDev/patch-1

Merge

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff KasumiDev/patch-1
git checkout master
git merge --ff-only KasumiDev/patch-1
git checkout KasumiDev/patch-1
git rebase master
git checkout master
git merge --no-ff KasumiDev/patch-1
git checkout master
git merge --squash KasumiDev/patch-1
git checkout master
git merge --ff-only KasumiDev/patch-1
git checkout master
git merge KasumiDev/patch-1
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Wrong-Place

This is the wrong place to write this

  
bug

Something isn't working

  
cli

Used for CLI problems

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
ice

This issue is currently on ice. It may be worked on in the feature, but not in the near future

  
invalid

This doesn't seem right

  
question

Further information is requested

  
request

Used this if you want to request e.g. a feature

  
wontfix

This will not be worked on

No labels
Wrong-Place
bug
cli
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
ice
invalid
question
request
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Creepso/multi-downloader-nx#738
No description provided.
Delete branch "KasumiDev/patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?