Creepso/multi-downloader-nx
1
0
Fork 0
Code Issues 38 Pull requests 10 Projects Releases 70 Packages Wiki Activity Actions

Rewrote file download and resolved issues #60

Closed
izu-co wants to merge 0 commits from master into master
pull from: master
merge into: Creepso:master
Conversation 11 Commits - Files changed -
izu-co commented 2021-05-03 17:52:41 +00:00 (Migrated from github.com)
Copy link
  • The download will now respect the parts and download them as given in the m3u8 file
  • Fixed broken audio files
- The download will now respect the parts and download them as given in the m3u8 file - Fixed broken audio files
izu-co commented 2021-05-03 17:54:24 +00:00 (Migrated from github.com)
Copy link

If you want me to change the version as well, just say so.

It would probably be for the best, since the normal beta 1 version isn't working.

If you want me to change the version as well, just say so. It would probably be for the best, since the normal beta 1 version isn't working.
storm134 commented 2021-05-03 22:40:14 +00:00 (Migrated from github.com)
Copy link

thanks just to let you know the search function is no longer working. show results but does not list show id

=== Funimation Downloader NX 4.8.0-beta.1 ===

[INFO] Search Results:
[INFO] Total shows found: 1

C:\funimation-downloader-nx-master>node funi.js --search hero

=== Funimation Downloader NX 4.8.0-beta.1 ===

[INFO] Search Results:
[INFO] Total shows found: 12

thanks just to let you know the search function is no longer working. show results but does not list show id === Funimation Downloader NX 4.8.0-beta.1 === [INFO] Search Results: [INFO] Total shows found: 1 C:\funimation-downloader-nx-master>node funi.js --search hero === Funimation Downloader NX 4.8.0-beta.1 === [INFO] Search Results: [INFO] Total shows found: 12
izu-co commented 2021-05-03 22:50:36 +00:00 (Migrated from github.com)
Copy link

Hey @storm134, thanks for the tip. It should be fixed with db5a607f74.

Hey @storm134, thanks for the tip. It should be fixed with https://github.com/anidl/funimation-downloader-nx/pull/60/commits/db5a607f7489555c9d64dd21505586a316a9bdbc.
izu-co commented 2021-05-04 12:48:11 +00:00 (Migrated from github.com)
Copy link

@anidl While running through the eslint errors, I noticed that proxies are currently not supported.
Should I try to fix it or remove it or leave it as it is?

@anidl While running through the eslint errors, I noticed that proxies are currently not supported. Should I try to fix it or remove it or leave it as it is?
STRAT4TR commented 2021-05-11 19:45:35 +00:00 (Migrated from github.com)
Copy link

Having a problem with Chinese shows, getting track not selected while trying to download Link Click
node funi -s 1456796 -e 1 -q 0 --sub
or
node funi -s 1456796 -e 1 -q 0
Will give the same message, "Track not selected"
Also having support for multisubs would be great, only the english subtitle is being downloaded at the moment.
The list of subs for the current season, from what I've seen on funimation (US)
portuguesebrazil_full.vtt
spanishlatinamerica_full.vtt
english_full.vtt

Having a problem with Chinese shows, getting track not selected while trying to download Link Click node funi -s 1456796 -e 1 -q 0 --sub or node funi -s 1456796 -e 1 -q 0 Will give the same message, "Track not selected" Also having support for multisubs would be great, only the english subtitle is being downloaded at the moment. The list of subs for the current season, from what I've seen on funimation (US) portuguesebrazil_full.vtt spanishlatinamerica_full.vtt english_full.vtt
STRAT4TR commented 2021-05-11 22:59:49 +00:00 (Migrated from github.com)
Copy link

Thanks for adding support for Chinese Funi shows.
Vivy 1394901, has 3 subs at the moment for all eps
Moriarty 1174922, has 3 subs at the moment for all eps, found them while using netmon

Thanks for adding support for Chinese Funi shows. Vivy 1394901, has 3 subs at the moment for all eps Moriarty 1174922, has 3 subs at the moment for all eps, found them while using netmon
STRAT4TR commented 2021-05-12 03:31:24 +00:00 (Migrated from github.com)
Copy link

node funi -s 1394901 -e 1 -q 0 --subLang "pt" --sub --novids --noaudio
It downloads the subtitle correctly, only 1 option can be chosen at time, could it be possible to add ".en" ".es" ".pt" to the converted file, eg: [Funi] Vivy -Fluorite Eye's Song- - 01 [1080p].en.ass
and for the vttconvert module instead of 'Title: English', having 'Title: ', would make the converter language agnostic

all these changes work without a problem now, thank you!

node funi -s 1394901 -e 1 -q 0 --subLang "pt" --sub --novids --noaudio It downloads the subtitle correctly, only 1 option can be chosen at time, could it be possible to add ".en" ".es" ".pt" to the converted file, eg: [Funi] Vivy -Fluorite Eye's Song- - 01 [1080p].en.ass and for the vttconvert module instead of 'Title: English', having 'Title: ', would make the converter language agnostic all these changes work without a problem now, thank you!
XxUnkn0wnxX commented 2021-05-16 13:42:48 +00:00 (Migrated from github.com)
Copy link

is this ever going to be merged into the main build? @anidl
any updates done to the main branch usually only happens once every 2-3 months.

atm main build can only download & not mux the files @izu-co has resolved pretty much all these issues...

is this ever going to be merged into the main build? @anidl any updates done to the main branch usually only happens once every 2-3 months. atm main build can only download & not mux the files @izu-co has resolved pretty much all these issues...
izu-co commented 2021-05-16 13:54:21 +00:00 (Migrated from github.com)
Copy link

Well you can't use the downloader at all, since it's not downloading the parts but the whole video like 720 times.

I published a fixed build on my fork atm.

Well you can't use the downloader at all, since it's not downloading the parts but the whole video like 720 times. I published a fixed build on my fork atm.
Oujiii commented 2021-05-23 11:20:15 +00:00 (Migrated from github.com)
Copy link

Quick question: What does passing -q do? Thank you for everything!

Quick question: What does passing `-q` do? Thank you for everything!
izu-co commented 2021-05-23 13:45:38 +00:00 (Migrated from github.com)
Copy link

@Oujiii It sets the quality. You can think of it as an ordered list (e.g. 360p, 440p, 720p, 1080p) and you select the number (1-10) which quality should be downloaded. Passing 0 will set it to best.

@Oujiii It sets the quality. You can think of it as an ordered list (e.g. 360p, 440p, 720p, 1080p) and you select the number (1-10) which quality should be downloaded. Passing 0 will set it to best.
👍 1

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Wrong-Place

This is the wrong place to write this

  
bug

Something isn't working

  
cli

Used for CLI problems

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
ice

This issue is currently on ice. It may be worked on in the feature, but not in the near future

  
invalid

This doesn't seem right

  
question

Further information is requested

  
request

Used this if you want to request e.g. a feature

  
wontfix

This will not be worked on

No labels
Wrong-Place
bug
cli
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
ice
invalid
question
request
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Creepso/multi-downloader-nx#60
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?