Fix fullscreen to the right

bhackel commented

2024-07-17 23:19:42 +00:00

(Migrated from github.com)

Hey @arichornloverALT so it turned out that this feature wasn't actually working, and I was mistaken when I was testing it. However, after some testing, I found the method that the app is using to check for the orientation that should be used. I was wondering why this was originally restricted to iPhone only. I have removed that restriction, but if you have a good reason for it, then I can add it back. Thanks

arichornloverALT commented

2024-07-18 10:46:41 +00:00

(Migrated from github.com)

Hey @arichornloverALT so it turned out that this feature wasn't actually working, and I was mistaken when I was testing it. However, after some testing, I found the method that the app is using to check for the orientation that should be used. I was wondering why this was originally restricted to iPhone only. I have removed that restriction, but if you have a good reason for it, then I can add it back. Thanks

I have had a good reason for it because the iPad version usually doesn’t automatically orientate to the left. It just goes in fullscreen based on what orientation the iPad is currently in. Restricting it was necessary because the iPad doesn’t necessarily need Fullscreen to the Right.

> Hey @arichornloverALT so it turned out that this feature wasn't actually working, and I was mistaken when I was testing it. However, after some testing, I found the method that the app is using to check for the orientation that should be used. I was wondering why this was originally restricted to iPhone only. I have removed that restriction, but if you have a good reason for it, then I can add it back. Thanks I have had a good reason for it because the iPad version usually doesn’t automatically orientate to the left. It just goes in fullscreen based on what orientation the iPad is currently in. Restricting it was necessary because the iPad doesn’t necessarily need Fullscreen to the Right.

bhackel commented

2024-07-18 19:14:23 +00:00

(Migrated from github.com)

I have had a good reason for it because the iPad version usually doesn’t automatically orientate to the left. It just goes in fullscreen based on what orientation the iPad is currently in. Restricting it was necessary because the iPad doesn’t necessarily need Fullscreen to the Right.

Sounds good I will add back the limitation

> I have had a good reason for it because the iPad version usually doesn’t automatically orientate to the left. It just goes in fullscreen based on what orientation the iPad is currently in. Restricting it was necessary because the iPad doesn’t necessarily need Fullscreen to the Right. Sounds good I will add back the limitation

👍 1

bhackel commented

2024-07-18 19:34:08 +00:00

(Migrated from github.com)

Actually do you think there might be people who would want to have this accessible on iPad? Not sure how YouTube on iPad works compared to iPhone. Let me know what you think

arichornloverALT commented

2024-07-18 20:16:24 +00:00

(Migrated from github.com)

Well, here’s what YouTube looks like on iPad.

https://github.com/user-attachments/assets/8b2eaab3-88d7-4860-afa5-ca87acc1caa6

I was even gonna merge this but seems like the Pull Request now has conflicts.

Well, here’s what YouTube looks like on iPad. https://github.com/user-attachments/assets/8b2eaab3-88d7-4860-afa5-ca87acc1caa6 I was even gonna merge this but seems like the Pull Request now has conflicts.

arichornloverALT commented

2024-07-18 20:38:17 +00:00

(Migrated from github.com)

Merged!

😆 2

Fix fullscreen to the right #250