Creepso/stremio-web
1
0
Fork 0
mirror of https://github.com/Stremio/stremio-web.git synced 2026-03-11 21:27:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

refactor(OptionsMenu): better naming

Browse source
This commit is contained in:
Tim 2023-01-12 22:07:43 +01:00
parent 72d4e740e1
commit dddc390952
2 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/routes/Player/OptionsMenu/Option/Option.js
View file

@ -7,12 +7,12 @@ const Icon = require('@stremio/stremio-icons/dom');
const { Button } = require('stremio/common');
const styles = require('./styles');
const Option = ({ icon, label, playerId, disabled, onClick }) => {
const Option = ({ icon, label, deviceId, disabled, onClick }) => {
const onButtonClick = React.useCallback(() => {
if (typeof onClick === 'function') {
onClick(playerId);
onClick(deviceId);
}
}, [onClick, playerId]);
}, [onClick, deviceId]);
return (
<Button className={classnames(styles['option-container'], { 'disabled': disabled })} disabled={disabled} onClick={onButtonClick}>
<Icon className={styles['icon']} icon={icon} />
@ -24,7 +24,7 @@ const Option = ({ icon, label, playerId, disabled, onClick }) => {
Option.propTypes = {
icon: PropTypes.string,
label: PropTypes.string,
playerId: PropTypes.string,
deviceId: PropTypes.string,
disabled: PropTypes.bool,
onClick: PropTypes.func,
};

10
src/routes/Player/OptionsMenu/OptionsMenu.js
View file

@ -22,7 +22,7 @@ const OptionsMenu = ({ className, stream, playbackDevices }) => {
:
null;
}, [stream]);
const externalPlayers = React.useMemo(() => {
const externalDevices = React.useMemo(() => {
return playbackDevices.filter(({ type }) => type === 'external');
}, [playbackDevices]);
const onCopyStreamButtonClick = React.useCallback(() => {
@ -52,7 +52,7 @@ const OptionsMenu = ({ className, stream, playbackDevices }) => {
window.open(streamUrl);
}
}, [streamUrl]);
const onExternalPlayRequested = React.useCallback((deviceId) => {
const onExternalDeviceRequested = React.useCallback((deviceId) => {
if (streamUrl !== null) {
core.transport.dispatch({
action: 'StreamingServer',
@ -84,14 +84,14 @@ const OptionsMenu = ({ className, stream, playbackDevices }) => {
onClick={onDownloadVideoButtonClick}
/>
{
!stream.infoHash && externalPlayers.map(({ id, name }) => (
!stream.infoHash && externalDevices.map(({ id, name }) => (
<Option
key={id}
icon={'ic_vlc'}
label={`Play in ${name}`}
playerId={id}
deviceId={id}
disabled={stream === null}
onClick={onExternalPlayRequested}
onClick={onExternalDeviceRequested}
/>
))
}