From abe42467addbe9c7085350844b5192024d6677bf Mon Sep 17 00:00:00 2001 From: kKaskak <117831817+kKaskak@users.noreply.github.com> Date: Tue, 27 Feb 2024 16:41:38 +0200 Subject: [PATCH] refactor: logic --- src/routes/Player/Player.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/routes/Player/Player.js b/src/routes/Player/Player.js index 0609d0d76..d6445f42a 100644 --- a/src/routes/Player/Player.js +++ b/src/routes/Player/Player.js @@ -462,13 +462,16 @@ const Player = ({ urlParams, queryParams }) => { }, []); React.useEffect(() => { - const controlBarLayerHeight = Math.round((controlBarRef?.current?.offsetHeight / window?.innerHeight) * 100); - if(controlBarRef.current !== null && video.state.subtitlesOffset < controlBarLayerHeight && controlBarLayerHeight !== null) { + let controlBarLayerHeight = Math.round((controlBarRef?.current?.offsetHeight / window?.innerHeight) * 100); + + if(video.state.subtitlesOffset < controlBarLayerHeight / 2) { + if (immersed) controlBarLayerHeight = 0; updateSettings({ subtitlesOffset: video.state.subtitlesOffset + controlBarLayerHeight }); - } else if (controlBarRef.current.offsetHeight === null || controlBarRef.current.offsetHeight === 0) { + } else { + controlBarLayerHeight = Math.round((controlBarRef?.current?.offsetHeight / window?.innerHeight) * 100); updateSettings({ subtitlesOffset: video.state.subtitlesOffset - controlBarLayerHeight }); } - }, [controlBarRef, video.state.subtitlesOffset]); + }, [immersed]); React.useLayoutEffect(() => { const onKeyDown = (event) => {