From f4531177d5f0d1f32cf20a1e266f3b037d0993b8 Mon Sep 17 00:00:00 2001 From: kKaskak <117831817+kKaskak@users.noreply.github.com> Date: Mon, 22 Apr 2024 14:08:17 +0300 Subject: [PATCH 1/5] fix: videos menu rendering conditions --- src/routes/Player/Player.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/routes/Player/Player.js b/src/routes/Player/Player.js index 3c79c3331..efd08c810 100644 --- a/src/routes/Player/Player.js +++ b/src/routes/Player/Player.js @@ -533,7 +533,7 @@ const Player = ({ urlParams, queryParams }) => { } case 'KeyV': { closeMenus(); - if (player.metaItem !== null && player.metaItem.type === 'Ready') { + if (player.metaItem !== null && player.metaItem.type === 'Ready' && player.metaItem.content.type === 'series') { toggleVideosMenu(); } From 0dbc4f759b186f30966e86b2af99c284940662d8 Mon Sep 17 00:00:00 2001 From: kKaskak <117831817+kKaskak@users.noreply.github.com> Date: Mon, 22 Apr 2024 14:08:37 +0300 Subject: [PATCH 2/5] feature: add shortcut to settings for videos menu --- src/routes/Settings/Settings.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/routes/Settings/Settings.js b/src/routes/Settings/Settings.js index 9dc6e3556..071f14d0e 100644 --- a/src/routes/Settings/Settings.js +++ b/src/routes/Settings/Settings.js @@ -694,6 +694,14 @@ const Settings = () => { I +
+
+
{ t('SETTINGS_SHORTCUT_MENU_VIDEOS') }
+
+
+ V +
+
{ t('SETTINGS_SHORTCUT_FULLSCREEN') }
From 36e3cf3a84f6b1b381f8b4e4b59796ba9cf11056 Mon Sep 17 00:00:00 2001 From: "Timothy Z." Date: Mon, 13 May 2024 16:05:02 +0300 Subject: [PATCH 3/5] refactor: change the rendering condition --- src/routes/Player/Player.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/routes/Player/Player.js b/src/routes/Player/Player.js index efd08c810..c52310886 100644 --- a/src/routes/Player/Player.js +++ b/src/routes/Player/Player.js @@ -533,7 +533,7 @@ const Player = ({ urlParams, queryParams }) => { } case 'KeyV': { closeMenus(); - if (player.metaItem !== null && player.metaItem.type === 'Ready' && player.metaItem.content.type === 'series') { + if (player.metaItem !== null && player.metaItem.type === 'Ready' && player.metaItem.content.videos !== null) { toggleVideosMenu(); } From afde589963ed254c66116ec806b73dabc5d1c315 Mon Sep 17 00:00:00 2001 From: "Timothy Z." Date: Mon, 13 May 2024 16:14:19 +0300 Subject: [PATCH 4/5] refactor: use llength as the condition --- src/routes/Player/Player.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/routes/Player/Player.js b/src/routes/Player/Player.js index c52310886..9dd5569e7 100644 --- a/src/routes/Player/Player.js +++ b/src/routes/Player/Player.js @@ -533,7 +533,7 @@ const Player = ({ urlParams, queryParams }) => { } case 'KeyV': { closeMenus(); - if (player.metaItem !== null && player.metaItem.type === 'Ready' && player.metaItem.content.videos !== null) { + if (player.metaItem !== null && player.metaItem.type === 'Ready' && player.metaItem.content.videos.length > 0) { toggleVideosMenu(); } From a659e88cfa826ac69d752e672648e9d9efde8794 Mon Sep 17 00:00:00 2001 From: "Timothy Z." Date: Mon, 13 May 2024 16:24:55 +0300 Subject: [PATCH 5/5] refactor: make sure error is not thrown when null --- src/routes/Player/Player.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/routes/Player/Player.js b/src/routes/Player/Player.js index 9dd5569e7..0a2efef8a 100644 --- a/src/routes/Player/Player.js +++ b/src/routes/Player/Player.js @@ -533,7 +533,7 @@ const Player = ({ urlParams, queryParams }) => { } case 'KeyV': { closeMenus(); - if (player.metaItem !== null && player.metaItem.type === 'Ready' && player.metaItem.content.videos.length > 0) { + if (player.metaItem !== null && player.metaItem.type === 'Ready' && player.metaItem?.content?.videos?.length > 0) { toggleVideosMenu(); }