From 6a2054372f5d29ed67e29e5e4e912e8065f623a4 Mon Sep 17 00:00:00 2001 From: Tim Date: Thu, 20 Mar 2025 15:30:13 +0100 Subject: [PATCH] refactor(ContextMenu): simplify useEffect --- src/components/ContextMenu/ContextMenu.tsx | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/components/ContextMenu/ContextMenu.tsx b/src/components/ContextMenu/ContextMenu.tsx index f9d125f2c..18368fbb7 100644 --- a/src/components/ContextMenu/ContextMenu.tsx +++ b/src/components/ContextMenu/ContextMenu.tsx @@ -58,12 +58,8 @@ const ContextMenu = ({ children, on, autoClose }: Props) => { }; useEffect(() => { - const containers = on.map((ref) => ref.current).filter((element) => !!element); - containers.forEach((container) => container.addEventListener('contextmenu', onContextMenu)); - - return () => { - containers.forEach((container) => container.removeEventListener('contextmenu', onContextMenu)); - }; + on.forEach((ref) => ref.current && ref.current.addEventListener('contextmenu', onContextMenu)); + return () => on.forEach((ref) => ref.current && ref.current.removeEventListener('contextmenu', onContextMenu)); }, [on]); return active && createPortal((