metaItem not required for InfoMenu

This commit is contained in:
nklhrstv 2020-04-01 15:39:36 +03:00
parent 8d9239acbf
commit 5cc640871c
2 changed files with 3 additions and 6 deletions

View file

@ -15,7 +15,6 @@ const ControlBar = ({
volume,
muted,
subtitlesTracks,
metaItem,
stream,
onPlayRequested,
onPauseRequested,
@ -98,7 +97,7 @@ const ControlBar = ({
<Button className={classnames(styles['control-bar-button'], 'disabled')} tabIndex={-1}>
<Icon className={styles['icon']} icon={'ic_network'} />
</Button>
<Button className={classnames(styles['control-bar-button'], { 'disabled': typeof metaItem !== 'object' || metaItem === null || typeof stream !== 'object' || stream === null })} tabIndex={-1} onMouseDown={onInfoButtonMouseDown} onClick={onInfoButtonClick}>
<Button className={classnames(styles['control-bar-button'], { 'disabled': typeof stream !== 'object' || stream === null })} tabIndex={-1} onMouseDown={onInfoButtonMouseDown} onClick={onInfoButtonClick}>
<Icon className={styles['icon']} icon={'ic_info'} />
</Button>
<Button className={classnames(styles['control-bar-button'], 'disabled')} tabIndex={-1}>
@ -123,7 +122,6 @@ ControlBar.propTypes = {
volume: PropTypes.number,
muted: PropTypes.bool,
subtitlesTracks: PropTypes.array,
metaItem: PropTypes.object,
stream: PropTypes.object,
onPlayRequested: PropTypes.func,
onPauseRequested: PropTypes.func,

View file

@ -296,7 +296,7 @@ const Player = ({ urlParams }) => {
}
case 'KeyM': {
closeSubtitlesMenu();
if (typeof metaItem === 'object' && metaItem !== null && typeof stream === 'object' && stream !== null) {
if (typeof stream === 'object' && stream !== null) {
toggleInfoMenu();
}
@ -315,7 +315,7 @@ const Player = ({ urlParams }) => {
return () => {
window.removeEventListener('keydown', onKeyDown);
};
}, [routeFocused, subtitlesMenuOpen, infoMenuOpen, stream, metaItem, videoState.paused, videoState.time, videoState.volume, videoState.subtitlesTracks, toggleSubtitlesMenu, toggleInfoMenu]);
}, [routeFocused, subtitlesMenuOpen, infoMenuOpen, stream, videoState.paused, videoState.time, videoState.volume, videoState.subtitlesTracks, toggleSubtitlesMenu, toggleInfoMenu]);
React.useLayoutEffect(() => {
return () => {
setImmersedDebounced.cancel();
@ -384,7 +384,6 @@ const Player = ({ urlParams }) => {
muted={videoState.muted}
subtitlesTracks={videoState.subtitlesTracks}
stream={stream}
metaItem={metaItem}
onPlayRequested={onPlayRequested}
onPauseRequested={onPauseRequested}
onMuteRequested={onMuteRequested}