From 8af7adaee97d529633defc85f9b142b8fcdb1a0e Mon Sep 17 00:00:00 2001 From: kKaskak <117831817+kKaskak@users.noreply.github.com> Date: Tue, 13 Feb 2024 23:17:23 +0100 Subject: [PATCH 1/4] fix: added code to prevent the onClick redirect --- src/common/MetaItem/MetaItem.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/common/MetaItem/MetaItem.js b/src/common/MetaItem/MetaItem.js index e9fc46dc8..2f277f9e9 100644 --- a/src/common/MetaItem/MetaItem.js +++ b/src/common/MetaItem/MetaItem.js @@ -41,6 +41,7 @@ const MetaItem = React.memo(({ className, type, name, poster, posterShape, poste } }, [props.onClick]); const menuOnClick = React.useCallback((event) => { + event.stopPropagation(); event.nativeEvent.selectPrevented = true; }, []); const menuOnSelect = React.useCallback((event) => { From f49be71bb59f52d5c6161a7ca2d5be399215af3d Mon Sep 17 00:00:00 2001 From: kKaskak <117831817+kKaskak@users.noreply.github.com> Date: Tue, 13 Feb 2024 23:24:58 +0100 Subject: [PATCH 2/4] delete: unnecessary nativeEvent --- src/common/MetaItem/MetaItem.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/common/MetaItem/MetaItem.js b/src/common/MetaItem/MetaItem.js index 2f277f9e9..913afd0ab 100644 --- a/src/common/MetaItem/MetaItem.js +++ b/src/common/MetaItem/MetaItem.js @@ -42,7 +42,6 @@ const MetaItem = React.memo(({ className, type, name, poster, posterShape, poste }, [props.onClick]); const menuOnClick = React.useCallback((event) => { event.stopPropagation(); - event.nativeEvent.selectPrevented = true; }, []); const menuOnSelect = React.useCallback((event) => { if (typeof optionOnSelect === 'function') { From 95e33666bd1339d88c3f683d9d0d0a314c901f8e Mon Sep 17 00:00:00 2001 From: kKaskak <117831817+kKaskak@users.noreply.github.com> Date: Tue, 13 Feb 2024 23:31:39 +0100 Subject: [PATCH 3/4] Revert "delete: unnecessary nativeEvent" This reverts commit f49be71bb59f52d5c6161a7ca2d5be399215af3d. --- src/common/MetaItem/MetaItem.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/common/MetaItem/MetaItem.js b/src/common/MetaItem/MetaItem.js index 913afd0ab..2f277f9e9 100644 --- a/src/common/MetaItem/MetaItem.js +++ b/src/common/MetaItem/MetaItem.js @@ -42,6 +42,7 @@ const MetaItem = React.memo(({ className, type, name, poster, posterShape, poste }, [props.onClick]); const menuOnClick = React.useCallback((event) => { event.stopPropagation(); + event.nativeEvent.selectPrevented = true; }, []); const menuOnSelect = React.useCallback((event) => { if (typeof optionOnSelect === 'function') { From 8f4bcb4d269e6768cde9eb467d781f16d40a1860 Mon Sep 17 00:00:00 2001 From: Tim Date: Thu, 15 Feb 2024 03:06:28 +0100 Subject: [PATCH 4/4] fix(MetaItem): libitems menu behavior --- src/common/MetaItem/MetaItem.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/common/MetaItem/MetaItem.js b/src/common/MetaItem/MetaItem.js index 2f277f9e9..00e2c6c99 100644 --- a/src/common/MetaItem/MetaItem.js +++ b/src/common/MetaItem/MetaItem.js @@ -32,16 +32,13 @@ const MetaItem = React.memo(({ className, type, name, poster, posterShape, poste null; }, [deepLinks]); const metaItemOnClick = React.useCallback((event) => { - if (typeof props.onClick === 'function') { - props.onClick(event); - } - if (event.nativeEvent.selectPrevented) { event.preventDefault(); + } else if (typeof props.onClick === 'function') { + props.onClick(event); } }, [props.onClick]); const menuOnClick = React.useCallback((event) => { - event.stopPropagation(); event.nativeEvent.selectPrevented = true; }, []); const menuOnSelect = React.useCallback((event) => {