From 76433a4b9a7ec9421d406a63ae7ce9db54c4a924 Mon Sep 17 00:00:00 2001 From: Alexandru Branza Date: Fri, 4 Feb 2022 16:14:43 +0200 Subject: [PATCH 1/6] Fix Discover Scroll The scroll of the Discover page would not go to top once a genre or page was changed. --- src/routes/Discover/Discover.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/routes/Discover/Discover.js b/src/routes/Discover/Discover.js index bbccda7a5..394f68ad1 100644 --- a/src/routes/Discover/Discover.js +++ b/src/routes/Discover/Discover.js @@ -67,6 +67,11 @@ const Discover = ({ urlParams, queryParams }) => { closeAddonModal(); setSelectedMetaItemIndex(0); }, [discover.selected]); + const metaItemsContainerRef = React.useRef(); + React.useEffect(() => { + if (((discover.catalog || {}).content || {}).type === 'Loading') + metaItemsContainerRef.current.scrollTo(0,0); + }, [discover.catalog]); return (
@@ -124,7 +129,7 @@ const Discover = ({ urlParams, queryParams }) => {
: discover.catalog.content.type === 'Loading' ? -
+
{Array(CONSTANTS.CATALOG_PAGE_SIZE).fill(null).map((_, index) => (
From 16e21b52415149fde801dc9399777b1067406c9d Mon Sep 17 00:00:00 2001 From: Alexandru Branza Date: Fri, 4 Feb 2022 16:50:08 +0200 Subject: [PATCH 2/6] Add Missing Space --- src/routes/Discover/Discover.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/routes/Discover/Discover.js b/src/routes/Discover/Discover.js index 394f68ad1..9b5d0d0e6 100644 --- a/src/routes/Discover/Discover.js +++ b/src/routes/Discover/Discover.js @@ -70,7 +70,7 @@ const Discover = ({ urlParams, queryParams }) => { const metaItemsContainerRef = React.useRef(); React.useEffect(() => { if (((discover.catalog || {}).content || {}).type === 'Loading') - metaItemsContainerRef.current.scrollTo(0,0); + metaItemsContainerRef.current.scrollTo(0, 0); }, [discover.catalog]); return ( From 328848fe168b70ad60ea55444d087fb10216a28c Mon Sep 17 00:00:00 2001 From: Alexandru Branza Date: Fri, 4 Feb 2022 17:01:53 +0200 Subject: [PATCH 3/6] Fallback to Using Addon Name if Stream Name is Missing --- src/routes/MetaDetails/StreamsList/Stream/Stream.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/routes/MetaDetails/StreamsList/Stream/Stream.js b/src/routes/MetaDetails/StreamsList/Stream/Stream.js index 386fc659d..df827548e 100644 --- a/src/routes/MetaDetails/StreamsList/Stream/Stream.js +++ b/src/routes/MetaDetails/StreamsList/Stream/Stream.js @@ -35,7 +35,7 @@ const Stream = ({ className, addonName, name, description, thumbnail, progress,
:
-
{name}
+
{name || addonName}
}
{description}
From cf3495bc7a18c6c70eb3fc1b2a53c88e3ce94fd9 Mon Sep 17 00:00:00 2001 From: Nikola Hristov Date: Tue, 15 Feb 2022 11:43:10 +0200 Subject: [PATCH 4/6] add addonName fallback to the title attribute too --- src/routes/MetaDetails/StreamsList/Stream/Stream.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/routes/MetaDetails/StreamsList/Stream/Stream.js b/src/routes/MetaDetails/StreamsList/Stream/Stream.js index df827548e..631085b8b 100644 --- a/src/routes/MetaDetails/StreamsList/Stream/Stream.js +++ b/src/routes/MetaDetails/StreamsList/Stream/Stream.js @@ -25,7 +25,7 @@ const Stream = ({ className, addonName, name, description, thumbnail, progress,