From 03ec592bf38f7b14c885a9ac63a1bdd75dbe0ddb Mon Sep 17 00:00:00 2001
From: kKaskak <117831817+kKaskak@users.noreply.github.com>
Date: Wed, 10 Jan 2024 18:11:26 +0200
Subject: [PATCH] refactor: add conditional check for opening the indicator

---
 src/routes/Player/Player.js | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/routes/Player/Player.js b/src/routes/Player/Player.js
index f5373aea1..3f1e9170e 100644
--- a/src/routes/Player/Player.js
+++ b/src/routes/Player/Player.js
@@ -157,11 +157,13 @@ const Player = ({ urlParams, queryParams }) => {
 
     const onVolumeChangeRequested = React.useCallback((volume) => {
         video.setProp('volume', volume);
-        openVolumeChangeIndicator();
+        if (immersed && !menusOpen) {
+            openVolumeChangeIndicator();
+        }
 
         if (volumeChangeTimeout.current) clearTimeout(volumeChangeTimeout.current);
         volumeChangeTimeout.current = setTimeout(closeVolumeChangeIndicator, 1500);
-    }, [openVolumeChangeIndicator, closeVolumeChangeIndicator]);
+    }, [immersed, menusOpen]);
 
     const onSeekRequested = React.useCallback((time) => {
         video.setProp('time', time);