Creepso/ryubing-ryujinx
1
0
Fork 0
mirror of https://git.ryujinx.app/ryubing/ryujinx.git synced 2026-05-24 05:22:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Suppress Invalid-texture-format log spam from uninitialized pool slots

Browse source 
UpdateFromPool iterates the full texture pool (sized by the guest's
MaximumId), which can exceed the slot range the guest has actually
populated. The trailing slots hold whatever was in guest memory at
allocation time; for pools filled with a poison byte (e.g. 0x5A) every
descriptor word is identical, the format lookup misses, and the existing
error log fires once per slot.

Skip the log when all eight descriptor words are bitwise equal. No real
descriptor has that shape, so this is a structural uninitialized-memory
test rather than a behaviour change; the lookup still falls back to
FormatInfo.Default as before.
This commit is contained in:
Jakob Linke 2026-05-22 15:57:12 +02:00
parent e2952ee6db
commit ada52eb61c
1 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/Ryujinx.Graphics.Gpu/Image/TexturePool.cs
View file

@ -529,6 +529,19 @@ namespace Ryujinx.Graphics.Gpu.Image
}
}
private static bool IsUninitializedDescriptor(in TextureDescriptor descriptor)
{
uint w = descriptor.Word0;
return descriptor.Word1 == w
&& descriptor.Word2 == w
&& descriptor.Word3 == w
&& descriptor.Word4 == w
&& descriptor.Word5 == w
&& descriptor.Word6 == w
&& descriptor.Word7 == w;
}
/// <summary>
/// Gets texture information from a texture descriptor.
/// </summary>
@ -586,7 +599,7 @@ namespace Ryujinx.Graphics.Gpu.Image
if (!FormatTable.TryGetTextureFormat(format, srgb, out FormatInfo formatInfo))
{
if (gpuVa != 0 && format != 0)
if (gpuVa != 0 && format != 0 && !IsUninitializedDescriptor(descriptor))
{
Logger.Error?.Print(LogClass.Gpu, $"Invalid texture format 0x{format:X} (sRGB: {srgb}).");
}