From b24ada9b77d40d563a83237dbacd1af4e0db8470 Mon Sep 17 00:00:00 2001
From: Pas <74743263+Pasithea0@users.noreply.github.com>
Date: Sat, 6 Dec 2025 21:48:28 -0700
Subject: [PATCH] Handle 'not found' state in embed source selection

Adds a 'notFound' state to useEmbedScraping and updates SourceSelectingView, SourceSelectPart, and SelectableLink to display a distinct UI when an embed source is not found. This improves user feedback for unavailable sources and refines error handling logic.
---
 .../atoms/settings/SourceSelectingView.tsx    | 18 ++++++++--
 .../player/hooks/useSourceSelection.ts        |  1 +
 .../player/internals/ContextMenu/Links.tsx    | 33 ++++++++++---------
 src/pages/parts/player/SourceSelectPart.tsx   | 22 +++++++++++--
 4 files changed, 55 insertions(+), 19 deletions(-)

diff --git a/src/components/player/atoms/settings/SourceSelectingView.tsx b/src/components/player/atoms/settings/SourceSelectingView.tsx
index e20bc6b2..6d15677b 100644
--- a/src/components/player/atoms/settings/SourceSelectingView.tsx
+++ b/src/components/player/atoms/settings/SourceSelectingView.tsx
@@ -39,19 +39,33 @@ export function EmbedOption(props: {
     return sourceMeta?.name ?? unknownEmbedName;
   }, [props.embedId, unknownEmbedName]);
 
-  const { run, errored, loading } = useEmbedScraping(
+  const { run, errored, loading, notFound } = useEmbedScraping(
     props.routerId,
     props.sourceId,
     props.url,
     props.embedId,
   );
 
+  let rightSide;
+  if (loading) {
+    rightSide = undefined; // Let SelectableLink handle loading
+  } else if (notFound) {
+    rightSide = (
+      <div className="flex items-center text-video-scraping-noresult">
+        <div className="w-4 h-4 rounded-full border-2 border-current bg-current flex items-center justify-center">
+          <div className="w-2 h-0.5 bg-background-main rounded-full" />
+        </div>
+      </div>
+    );
+  }
+
   return (
     <SelectableLink
       loading={loading}
-      error={errored}
+      error={errored && !notFound}
       onClick={run}
       selected={props.embedId === currentEmbedId}
+      rightSide={rightSide}
     >
       <span className="flex flex-col">
         <span>{embedName}</span>
diff --git a/src/components/player/hooks/useSourceSelection.ts b/src/components/player/hooks/useSourceSelection.ts
index 4fca0775..dde82db0 100644
--- a/src/components/player/hooks/useSourceSelection.ts
+++ b/src/components/player/hooks/useSourceSelection.ts
@@ -124,6 +124,7 @@ export function useEmbedScraping(
     run,
     loading: request.loading,
     errored: !!request.error,
+    notFound: request.error instanceof NotFoundError,
   };
 }
 
diff --git a/src/components/player/internals/ContextMenu/Links.tsx b/src/components/player/internals/ContextMenu/Links.tsx
index 7d53e264..a1cb459f 100644
--- a/src/components/player/internals/ContextMenu/Links.tsx
+++ b/src/components/player/internals/ContextMenu/Links.tsx
@@ -169,23 +169,26 @@ export function SelectableLink(props: {
   disabled?: boolean;
   error?: ReactNode;
   box?: boolean;
+  rightSide?: ReactNode;
 }) {
-  let rightContent;
-  if (props.selected) {
-    rightContent = (
-      <Icon
-        icon={Icons.CIRCLE_CHECK}
-        className="text-xl text-video-context-type-accent"
-      />
-    );
+  let rightContent = props.rightSide; // Use custom rightSide if provided
+  if (!rightContent) {
+    if (props.selected) {
+      rightContent = (
+        <Icon
+          icon={Icons.CIRCLE_CHECK}
+          className="text-xl text-video-context-type-accent"
+        />
+      );
+    }
+    if (props.error)
+      rightContent = (
+        <span className="flex items-center text-video-context-error">
+          <Icon className="ml-2" icon={Icons.WARNING} />
+        </span>
+      );
+    if (props.loading) rightContent = <Spinner className="text-lg" />; // should override selected and error
   }
-  if (props.error)
-    rightContent = (
-      <span className="flex items-center text-video-context-error">
-        <Icon className="ml-2" icon={Icons.WARNING} />
-      </span>
-    );
-  if (props.loading) rightContent = <Spinner className="text-lg" />; // should override selected and error
 
   return (
     <Link
diff --git a/src/pages/parts/player/SourceSelectPart.tsx b/src/pages/parts/player/SourceSelectPart.tsx
index 6c6f4d8e..201f456c 100644
--- a/src/pages/parts/player/SourceSelectPart.tsx
+++ b/src/pages/parts/player/SourceSelectPart.tsx
@@ -28,15 +28,33 @@ function EmbedOption(props: {
     return sourceMeta?.name ?? unknownEmbedName;
   }, [props.embedId, unknownEmbedName]);
 
-  const { run, errored, loading } = useEmbedScraping(
+  const { run, errored, loading, notFound } = useEmbedScraping(
     props.routerId,
     props.sourceId,
     props.url,
     props.embedId,
   );
 
+  let rightSide;
+  if (loading) {
+    rightSide = undefined; // Let SelectableLink handle loading
+  } else if (notFound) {
+    rightSide = (
+      <div className="flex items-center text-video-scraping-noresult">
+        <div className="w-4 h-4 rounded-full border-2 border-current bg-current flex items-center justify-center">
+          <div className="w-2 h-0.5 bg-background-main rounded-full" />
+        </div>
+      </div>
+    );
+  }
+
   return (
-    <SelectableLink loading={loading} error={errored} onClick={run}>
+    <SelectableLink
+      loading={loading}
+      error={errored && !notFound}
+      onClick={run}
+      rightSide={rightSide}
+    >
       <span className="flex flex-col">
         <span>{embedName}</span>
       </span>