From a0bb03790a37fad2eed1ab15f4ada9814a84dc45 Mon Sep 17 00:00:00 2001
From: Jordaar <69628820+Jordaar@users.noreply.github.com>
Date: Fri, 16 Jun 2023 16:14:05 +0530
Subject: [PATCH] refactor(streamsb): improve quality sorting

---
 src/backend/embeds/streamsb.ts | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/backend/embeds/streamsb.ts b/src/backend/embeds/streamsb.ts
index 99ed563e..e91b43c7 100644
--- a/src/backend/embeds/streamsb.ts
+++ b/src/backend/embeds/streamsb.ts
@@ -100,7 +100,7 @@ registerEmbedScraper({
       "[onclick^=download_video]"
     );
 
-    const dlDetails = [];
+    let dlDetails = [];
     for (const func of downloadVideoFunctions) {
       const funcContents = func.getAttribute("onclick");
       const regExpFunc = /download_video\('(.+?)','(.+?)','(.+?)'\)/;
@@ -121,6 +121,12 @@ registerEmbedScraper({
       }
     }
 
+    dlDetails = dlDetails.sort((a, b) => {
+      const aQuality = qualityOrder.indexOf(a.quality.label as MWStreamQuality);
+      const bQuality = qualityOrder.indexOf(b.quality.label as MWStreamQuality);
+      return aQuality - bQuality;
+    });
+
     progress(40);
 
     let dls = await Promise.all(
@@ -187,11 +193,6 @@ registerEmbedScraper({
       })
     );
     dls = dls.filter((d) => !!d.url);
-    dls = dls.sort((a, b) => {
-      const aQuality = qualityOrder.indexOf(a.quality);
-      const bQuality = qualityOrder.indexOf(b.quality);
-      return aQuality - bQuality;
-    });
 
     progress(60);