From 29ca428b6aaf1d5af5b92ab5116bd0e2ad54b76d Mon Sep 17 00:00:00 2001
From: Pas <74743263+Pasithea0@users.noreply.github.com>
Date: Mon, 2 Jun 2025 12:38:55 -0600
Subject: [PATCH] Remove media card overlay

---
 src/components/media/MediaCard.tsx | 494 ++++++++---------------------
 1 file changed, 140 insertions(+), 354 deletions(-)

diff --git a/src/components/media/MediaCard.tsx b/src/components/media/MediaCard.tsx
index 9cff8a19..4422d84c 100644
--- a/src/components/media/MediaCard.tsx
+++ b/src/components/media/MediaCard.tsx
@@ -1,20 +1,19 @@
 // I'm sorry this is so confusing 😭
 
 import classNames from "classnames";
-import { useCallback, useRef, useState } from "react";
+import { useCallback, useState } from "react";
 import { useTranslation } from "react-i18next";
 import { Link } from "react-router-dom";
-import { useCopyToClipboard } from "react-use";
 
 import { mediaItemToId } from "@/backend/metadata/tmdb";
 import { DotList } from "@/components/text/DotList";
 import { Flare } from "@/components/utils/Flare";
+import { useIsMobile } from "@/hooks/useIsMobile";
 import { useSearchQuery } from "@/hooks/useSearchQuery";
 import { usePreferencesStore } from "@/stores/preferences";
 import { MediaItem } from "@/utils/mediaTypes";
 
 import { MediaBookmarkButton } from "./MediaBookmark";
-import { Button } from "../buttons/Button";
 import { IconPatch } from "../buttons/IconPatch";
 import { Icon, Icons } from "../Icon";
 import { DetailsModal } from "../overlays/details/DetailsModal";
@@ -49,10 +48,6 @@ function checkReleased(media: MediaItem): boolean {
   return isReleased;
 }
 
-function getBaseUrl(): string {
-  return window.location.origin;
-}
-
 function MediaCardContent({
   media,
   linkable,
@@ -60,23 +55,11 @@ function MediaCardContent({
   percentage,
   closable,
   onClose,
-  overlayVisible,
-  setOverlayVisible,
-  handleMouseEnter,
-  handleMouseLeave,
-  link,
-  isHoveringCard,
   onShowDetails,
-}: MediaCardProps & {
-  overlayVisible: boolean;
-  setOverlayVisible: React.Dispatch<React.SetStateAction<boolean>>;
-  handleMouseEnter: () => void;
-  handleMouseLeave: () => void;
-  link: string;
-  isHoveringCard: boolean;
-}) {
+}: MediaCardProps) {
   const { t } = useTranslation();
   const percentageString = `${Math.round(percentage ?? 0).toFixed(0)}%`;
+  const { isMobile } = useIsMobile();
 
   const isReleased = useCallback(() => checkReleased(media), [media]);
 
@@ -84,19 +67,8 @@ function MediaCardContent({
 
   const dotListContent = [t(`media.types.${media.type}`)];
 
-  const altDotListContent = [t(`ID: ${media.id}`)];
-
   const [searchQuery] = useSearchQuery();
 
-  const [, copyToClipboard] = useCopyToClipboard();
-  const [hasCopied, setHasCopied] = useState(false);
-
-  const [hasCopiedID, setHasCopiedID] = useState(false);
-
-  if (closable) {
-    setOverlayVisible(false);
-  }
-
   if (isReleased() && media.year) {
     dotListContent.push(media.year.toFixed());
   }
@@ -105,252 +77,146 @@ function MediaCardContent({
     dotListContent.push(t("media.unreleased"));
   }
 
-  const handleCopyClick = (
-    e: React.MouseEvent<HTMLButtonElement | HTMLAnchorElement>,
-  ) => {
-    e.preventDefault();
-    copyToClipboard(link);
-    setHasCopied(true);
-    setTimeout(() => setHasCopied(false), 2000);
-  };
-
-  const handleCopyIDClick = (
-    e: React.MouseEvent<HTMLButtonElement | HTMLAnchorElement>,
-  ) => {
-    e.preventDefault();
-    copyToClipboard(media.id);
-    setHasCopiedID(true);
-    setTimeout(() => setHasCopiedID(false), 2000);
-  };
-
   return (
-    <div
-      className={classNames("media-card-content", { jiggle: closable })}
-      onMouseEnter={handleMouseEnter}
-      onMouseLeave={handleMouseLeave}
+    <Flare.Base
+      className={`group -m-[0.705em] rounded-xl bg-background-main transition-colors duration-300 focus:relative focus:z-10 ${
+        canLink ? "hover:bg-mediaCard-hoverBackground tabbable" : ""
+      }`}
+      tabIndex={canLink ? 0 : -1}
+      onKeyUp={(e) => e.key === "Enter" && e.currentTarget.click()}
     >
-      <Flare.Base
-        className={`group -m-[0.705em] rounded-xl bg-background-main transition-colors duration-300 focus:relative focus:z-10 ${
-          canLink ? "hover:bg-mediaCard-hoverBackground tabbable" : ""
+      <Flare.Light
+        flareSize={300}
+        cssColorVar="--colors-mediaCard-hoverAccent"
+        backgroundClass="bg-mediaCard-hoverBackground duration-100"
+        className={classNames({
+          "rounded-xl bg-background-main group-hover:opacity-100": canLink,
+        })}
+      />
+      <Flare.Child
+        className={`pointer-events-auto relative mb-2 p-[0.4em] transition-transform duration-300 ${
+          canLink ? "group-hover:scale-95" : "opacity-60"
         }`}
-        tabIndex={canLink ? 0 : -1}
-        onKeyUp={(e) => e.key === "Enter" && e.currentTarget.click()}
       >
-        <Flare.Light
-          flareSize={300}
-          cssColorVar="--colors-mediaCard-hoverAccent"
-          backgroundClass="bg-mediaCard-hoverBackground duration-100"
-          className={classNames({
-            "rounded-xl bg-background-main group-hover:opacity-100": canLink,
-          })}
-        />
-        <Flare.Child
-          className={`pointer-events-auto relative mb-2 p-[0.4em] transition-transform duration-300 ${
-            canLink ? (isHoveringCard ? "scale-95" : "") : "opacity-60"
-          }`}
+        <div
+          className={classNames(
+            "relative mb-4 pb-[150%] w-full overflow-hidden rounded-xl bg-mediaCard-hoverBackground bg-cover bg-center transition-[border-radius] duration-300",
+            {
+              "group-hover:rounded-lg": canLink,
+            },
+          )}
+          style={{
+            backgroundImage: media.poster ? `url(${media.poster})` : undefined,
+          }}
         >
-          <div
-            className={classNames(
-              "relative mb-4 pb-[150%] w-full overflow-hidden rounded-xl bg-mediaCard-hoverBackground bg-cover bg-center transition-[border-radius] duration-300",
-              {
-                "group-hover:rounded-lg": canLink,
-                "blur-sm": overlayVisible,
-              },
-            )}
-            style={{
-              backgroundImage: media.poster
-                ? overlayVisible
-                  ? `linear-gradient(rgba(0, 0, 0, 0.2), rgba(0, 0, 0, 0.8)), url(${media.poster})`
-                  : `url(${media.poster})`
-                : undefined,
-            }}
-          >
-            {!overlayVisible ? (
-              <div>
-                {series ? (
+          {series ? (
+            <div
+              className={[
+                "absolute right-2 top-2 rounded-md bg-mediaCard-badge px-2 py-1 transition-colors",
+              ].join(" ")}
+            >
+              <p
+                className={[
+                  "text-center text-xs font-bold text-mediaCard-badgeText transition-colors",
+                  closable ? "" : "group-hover:text-white",
+                ].join(" ")}
+              >
+                {t("media.episodeDisplay", {
+                  season: series.season || 1,
+                  episode: series.episode,
+                })}
+              </p>
+            </div>
+          ) : null}
+
+          {percentage !== undefined ? (
+            <>
+              <div
+                className={`absolute inset-x-0 -bottom-px pb-1 h-12 bg-gradient-to-t from-mediaCard-shadow to-transparent transition-colors ${
+                  canLink ? "group-hover:from-mediaCard-hoverShadow" : ""
+                }`}
+              />
+              <div
+                className={`absolute inset-x-0 bottom-0 h-12 bg-gradient-to-t from-mediaCard-shadow to-transparent transition-colors ${
+                  canLink ? "group-hover:from-mediaCard-hoverShadow" : ""
+                }`}
+              />
+              <div className="absolute inset-x-0 bottom-0 p-3">
+                <div className="relative h-1 overflow-hidden rounded-full bg-mediaCard-barColor">
                   <div
-                    className={[
-                      "absolute right-2 top-2 rounded-md bg-mediaCard-badge px-2 py-1 transition-colors",
-                    ].join(" ")}
-                  >
-                    <p
-                      className={[
-                        "text-center text-xs font-bold text-mediaCard-badgeText transition-colors",
-                        closable ? "" : "group-hover:text-white",
-                      ].join(" ")}
-                    >
-                      {t("media.episodeDisplay", {
-                        season: series.season || 1,
-                        episode: series.episode,
-                      })}
-                    </p>
-                  </div>
-                ) : null}
-
-                {percentage !== undefined ? (
-                  <>
-                    <div
-                      className={`absolute inset-x-0 -bottom-px pb-1 h-12 bg-gradient-to-t from-mediaCard-shadow to-transparent transition-colors ${
-                        canLink ? "group-hover:from-mediaCard-hoverShadow" : ""
-                      }`}
-                    />
-                    <div
-                      className={`absolute inset-x-0 bottom-0 h-12 bg-gradient-to-t from-mediaCard-shadow to-transparent transition-colors ${
-                        canLink ? "group-hover:from-mediaCard-hoverShadow" : ""
-                      }`}
-                    />
-                    <div className="absolute inset-x-0 bottom-0 p-3">
-                      <div className="relative h-1 overflow-hidden rounded-full bg-mediaCard-barColor">
-                        <div
-                          className="absolute inset-y-0 left-0 rounded-full bg-mediaCard-barFillColor"
-                          style={{
-                            width: percentageString,
-                          }}
-                        />
-                      </div>
-                    </div>
-                  </>
-                ) : null}
-              </div>
-            ) : null}
-
-            {!overlayVisible ? (
-              <div>
-                {!closable ? (
-                  <div>
-                    <div
-                      className="absolute bookmark-button"
-                      onClick={(e) => e.preventDefault()}
-                    >
-                      <MediaBookmarkButton media={media} />
-                    </div>
-                    {searchQuery.length > 0 ? (
-                      <div
-                        className="absolute"
-                        onClick={(e) => e.preventDefault()}
-                      >
-                        <MediaBookmarkButton media={media} />
-                      </div>
-                    ) : null}
-                  </div>
-                ) : null}
-                <div
-                  className={`absolute inset-0 flex items-center justify-center bg-mediaCard-badge bg-opacity-80 transition-opacity duration-500 ${
-                    closable ? "opacity-100" : "pointer-events-none opacity-0"
-                  }`}
-                >
-                  <IconPatch
-                    clickable
-                    className="text-2xl text-mediaCard-badgeText transition-transform hover:scale-110 duration-500"
-                    onClick={() => closable && onClose?.()}
-                    icon={Icons.X}
+                    className="absolute inset-y-0 left-0 rounded-full bg-mediaCard-barFillColor"
+                    style={{
+                      width: percentageString,
+                    }}
                   />
                 </div>
               </div>
-            ) : null}
-          </div>
+            </>
+          ) : null}
 
-          {overlayVisible ? (
-            <div>
-              <div className="absolute inset-0 flex flex-col items-center justify-start gap-y-2 pt-8 md:pt-12">
-                <Button
-                  theme="glass"
-                  className="w-[86%] md:w-[90%] h-12 rounded-lg px-4 py-2 my-1"
-                  onClick={(e) => {
-                    e.preventDefault();
-                    e.stopPropagation();
-                    if (onShowDetails) onShowDetails(media);
-                  }}
-                >
-                  {t("home.mediaCard.moreInfo")}
-                </Button>
+          {!closable && (
+            <div
+              className={classNames("absolute", {
+                "bookmark-button": !isMobile,
+              })}
+              onClick={(e) => e.preventDefault()}
+            >
+              <MediaBookmarkButton media={media} />
+            </div>
+          )}
 
-                {canLink ? (
-                  <Button
-                    theme="glass"
-                    className="w-[86%] md:w-[90%] h-12 rounded-lg px-4 py-2 my-1"
-                    href={link}
-                    onClick={handleCopyClick}
-                  >
-                    {hasCopied ? (
-                      <Icon
-                        className="text-md text-white mix-blend-screen"
-                        icon={Icons.CHECKMARK}
-                      />
-                    ) : (
-                      t("home.mediaCard.copyLink")
-                    )}
-                  </Button>
-                ) : null}
-
-                <Button
-                  theme="glass"
-                  className="w-[86%] md:w-[90%] h-12 rounded-lg px-4 py-2 my-1"
-                  onClick={() => setOverlayVisible(false)}
-                >
-                  {t("home.mediaCard.close")}
-                </Button>
-              </div>
+          {searchQuery.length > 0 && !closable ? (
+            <div className="absolute" onClick={(e) => e.preventDefault()}>
+              <MediaBookmarkButton media={media} />
             </div>
           ) : null}
 
-          <h1 className="mb-1 line-clamp-3 max-h-[4.5rem] text-ellipsis break-words font-bold text-white">
-            <span>{media.title}</span>
-          </h1>
-          <div className="media-info-container justify-content-center flex flex-wrap">
-            {!overlayVisible ? (
-              <DotList className="text-xs" content={dotListContent} />
-            ) : (
-              <button
-                type="button"
-                onClick={handleCopyIDClick}
-                className="z-50"
-              >
-                {!hasCopiedID ? (
-                  <DotList className="text-xs" content={altDotListContent} />
-                ) : (
-                  <div className="flex items-center gap-1">
-                    <DotList className="text-xs" content={altDotListContent} />
-                    <Icon
-                      className="text-xs text-type-secondary"
-                      icon={Icons.CHECKMARK}
-                    />
-                  </div>
-                )}
-              </button>
-            )}
+          <div
+            className={`absolute inset-0 flex items-center justify-center bg-mediaCard-badge bg-opacity-80 transition-opacity duration-500 ${
+              closable ? "opacity-100" : "pointer-events-none opacity-0"
+            }`}
+          >
+            <IconPatch
+              clickable
+              className="text-2xl text-mediaCard-badgeText transition-transform hover:scale-110 duration-500"
+              onClick={() => closable && onClose?.()}
+              icon={Icons.X}
+            />
           </div>
+        </div>
 
-          {!overlayVisible && !closable ? (
-            <div className="absolute bottom-0 translate-y-1 right-1">
-              <button
-                className="media-more-button p-2"
-                type="button"
-                onClick={(e) => {
-                  e.preventDefault();
-                  e.stopPropagation();
-                  setOverlayVisible(!overlayVisible);
-                }}
-              >
-                <Icon
-                  className="text-xs font-semibold text-type-secondary"
-                  icon={Icons.ELLIPSIS}
-                />
-              </button>
-            </div>
-          ) : null}
-        </Flare.Child>
-      </Flare.Base>
-    </div>
+        <h1 className="mb-1 line-clamp-3 max-h-[4.5rem] text-ellipsis break-words font-bold text-white">
+          <span>{media.title}</span>
+        </h1>
+        <div className="media-info-container justify-content-center flex flex-wrap">
+          <DotList className="text-xs" content={dotListContent} />
+        </div>
+
+        {!closable && (
+          <div className="absolute bottom-0 translate-y-1 right-1">
+            <button
+              className="media-more-button p-2"
+              type="button"
+              onClick={(e) => {
+                e.preventDefault();
+                e.stopPropagation();
+                onShowDetails?.(media);
+              }}
+            >
+              <Icon
+                className="text-xs font-semibold text-type-secondary"
+                icon={Icons.ELLIPSIS}
+              />
+            </button>
+          </div>
+        )}
+      </Flare.Child>
+    </Flare.Base>
   );
 }
 
 export function MediaCard(props: MediaCardProps) {
   const { media, onShowDetails } = props;
-  const [overlayVisible, setOverlayVisible] = useState(false);
-  const [timeoutId, setTimeoutId] = useState<NodeJS.Timeout | null>(null);
-  const hoverTimer = useRef<NodeJS.Timeout>();
-  const [isHoveringCard, setIsHoveringCard] = useState(false);
   const [detailsData, setDetailsData] = useState<{
     id: number;
     type: "movie" | "show";
@@ -360,36 +226,6 @@ export function MediaCard(props: MediaCardProps) {
     (state) => state.enableDetailsModal,
   );
 
-  const handleMouseEnter = () => {
-    setIsHoveringCard(true);
-
-    if (timeoutId) {
-      clearTimeout(timeoutId);
-      setTimeoutId(null);
-    }
-
-    if (hoverTimer.current) {
-      clearTimeout(hoverTimer.current);
-    }
-  };
-
-  const handleMouseLeave = () => {
-    setIsHoveringCard(false);
-    if (hoverTimer.current) {
-      clearTimeout(hoverTimer.current);
-    }
-
-    const id = setTimeout(() => {
-      setOverlayVisible(false);
-    }, 2000); // 2 seconds
-    setTimeoutId(id);
-  };
-
-  const handleContextMenu = (e: React.MouseEvent) => {
-    e.preventDefault();
-    setOverlayVisible(true);
-  };
-
   const isReleased = useCallback(
     () => checkReleased(props.media),
     [props.media],
@@ -398,7 +234,7 @@ export function MediaCard(props: MediaCardProps) {
   const canLink = props.linkable && !props.closable && isReleased();
 
   let link = canLink
-    ? `${getBaseUrl()}/media/${encodeURIComponent(mediaItemToId(props.media))}`
+    ? `/media/${encodeURIComponent(mediaItemToId(props.media))}`
     : "#";
   if (canLink && props.series) {
     if (props.series.season === 0 && !props.series.episodeId) {
@@ -427,92 +263,42 @@ export function MediaCard(props: MediaCardProps) {
     if (enableDetailsModal && canLink) {
       e.preventDefault();
       handleShowDetails();
-    } else if (overlayVisible || e.defaultPrevented) {
-      e.preventDefault();
     }
   };
 
   const content = (
     <>
-      <MediaCardContent
-        {...props}
-        overlayVisible={overlayVisible}
-        setOverlayVisible={setOverlayVisible}
-        handleMouseEnter={handleMouseEnter}
-        handleMouseLeave={handleMouseLeave}
-        link={link}
-        isHoveringCard={isHoveringCard}
-        onShowDetails={handleShowDetails}
-      />
+      <MediaCardContent {...props} onShowDetails={handleShowDetails} />
       {detailsData && <DetailsModal id="details" data={detailsData} />}
     </>
   );
 
-  if (!canLink)
+  if (!canLink) {
     return (
       <span
         className="relative"
-        onMouseEnter={handleMouseEnter}
-        onMouseLeave={handleMouseLeave}
-        onContextMenu={handleContextMenu}
         onClick={(e) => {
-          if (overlayVisible || e.defaultPrevented) {
+          if (e.defaultPrevented) {
             e.preventDefault();
           }
         }}
       >
-        {content}{" "}
+        {content}
       </span>
     );
+  }
+
   return (
-    <div className="relative">
-      {!overlayVisible ? (
-        <Link
-          to={link}
-          tabIndex={-1}
-          className={classNames(
-            "tabbable",
-            props.closable ? "hover:cursor-default" : "",
-          )}
-          onMouseEnter={handleMouseEnter}
-          onMouseLeave={handleMouseLeave}
-          onContextMenu={handleContextMenu}
-          onClick={handleCardClick}
-        >
-          <MediaCardContent
-            {...props}
-            overlayVisible={overlayVisible}
-            setOverlayVisible={setOverlayVisible}
-            handleMouseEnter={handleMouseEnter}
-            handleMouseLeave={handleMouseLeave}
-            link={link}
-            isHoveringCard={isHoveringCard}
-            onShowDetails={handleShowDetails}
-          />
-        </Link>
-      ) : (
-        <div
-          tabIndex={-1}
-          className={classNames(
-            "tabbable",
-            props.closable ? "hover:cursor-default" : "",
-          )}
-          onMouseEnter={handleMouseEnter}
-          onMouseLeave={handleMouseLeave}
-          onContextMenu={handleContextMenu}
-        >
-          <MediaCardContent
-            {...props}
-            overlayVisible={overlayVisible}
-            setOverlayVisible={setOverlayVisible}
-            handleMouseEnter={handleMouseEnter}
-            handleMouseLeave={handleMouseLeave}
-            link={link}
-            isHoveringCard={isHoveringCard}
-            onShowDetails={handleShowDetails}
-          />
-        </div>
+    <Link
+      to={link}
+      tabIndex={-1}
+      className={classNames(
+        "tabbable",
+        props.closable ? "hover:cursor-default" : "",
       )}
-    </div>
+      onClick={handleCardClick}
+    >
+      {content}
+    </Link>
   );
 }