From 0ed041fe931d7042f06ea6bc905f822255d30fbf Mon Sep 17 00:00:00 2001
From: Pas <74743263+Pasithea0@users.noreply.github.com>
Date: Fri, 7 Nov 2025 15:39:33 -0700
Subject: [PATCH] update subtitle defaults

---
 src/assets/locales/en.json                    |  4 +-
 .../atoms/settings/CaptionSettingsView.tsx    | 43 ++++++++++---------
 src/pages/parts/settings/CaptionsPart.tsx     | 36 ++++++++--------
 src/stores/subtitles/index.ts                 |  4 +-
 4 files changed, 45 insertions(+), 42 deletions(-)

diff --git a/src/assets/locales/en.json b/src/assets/locales/en.json
index 7943a048..5ba257bc 100644
--- a/src/assets/locales/en.json
+++ b/src/assets/locales/en.json
@@ -1159,8 +1159,8 @@
       "title": "Subtitles",
       "textBoldLabel": "Bold text",
       "verticalPositionLabel": "Vertical position",
-      "default": "Default",
-      "low": "Low",
+      "high": "High",
+      "low": "Default",
       "textStyle": {
         "title": "Text style",
         "default": "Default",
diff --git a/src/components/player/atoms/settings/CaptionSettingsView.tsx b/src/components/player/atoms/settings/CaptionSettingsView.tsx
index 954e7ddc..20ad2e59 100644
--- a/src/components/player/atoms/settings/CaptionSettingsView.tsx
+++ b/src/components/player/atoms/settings/CaptionSettingsView.tsx
@@ -12,6 +12,7 @@ import { useProgressBar } from "@/hooks/useProgressBar";
 import { usePlayerStore } from "@/stores/player/store";
 import { usePreferencesStore } from "@/stores/preferences";
 import { SubtitleStyling, useSubtitleStore } from "@/stores/subtitles";
+import { isFirefox } from "@/utils/detectFeatures";
 
 export function ColorOption(props: {
   color: string;
@@ -423,10 +424,12 @@ export function CaptionSettingsView({
   const resetSubStyling = () => {
     subtitleStore.updateStyling({
       color: "#ffffff",
-      backgroundOpacity: 0.5,
-      size: 1,
-      backgroundBlur: 0.5,
+      backgroundOpacity: 0.25,
+      size: 0.75,
+      backgroundBlur: 0.25,
+      backgroundBlurEnabled: !isFirefox,
       bold: false,
+      verticalPosition: 1,
       fontStyle: "default",
       borderThickness: 1,
     });
@@ -635,23 +638,6 @@ export function CaptionSettingsView({
                 {t("settings.subtitles.verticalPositionLabel")}
               </Menu.FieldTitle>
               <div className="flex justify-center items-center space-x-2">
-                <button
-                  type="button"
-                  className={classNames(
-                    "px-3 py-1 rounded transition-colors duration-100",
-                    styling.verticalPosition === 3
-                      ? "bg-video-context-buttonFocus"
-                      : "bg-video-context-buttonFocus bg-opacity-0 hover:bg-opacity-50",
-                  )}
-                  onClick={() =>
-                    handleStylingChange({
-                      ...styling,
-                      verticalPosition: 3,
-                    })
-                  }
-                >
-                  {t("settings.subtitles.default")}
-                </button>
                 <button
                   type="button"
                   className={classNames(
@@ -669,6 +655,23 @@ export function CaptionSettingsView({
                 >
                   {t("settings.subtitles.low")}
                 </button>
+                <button
+                  type="button"
+                  className={classNames(
+                    "px-3 py-1 rounded transition-colors duration-100",
+                    styling.verticalPosition === 3
+                      ? "bg-video-context-buttonFocus"
+                      : "bg-video-context-buttonFocus bg-opacity-0 hover:bg-opacity-50",
+                  )}
+                  onClick={() =>
+                    handleStylingChange({
+                      ...styling,
+                      verticalPosition: 3,
+                    })
+                  }
+                >
+                  {t("settings.subtitles.high")}
+                </button>
               </div>
             </div>
             <Button
diff --git a/src/pages/parts/settings/CaptionsPart.tsx b/src/pages/parts/settings/CaptionsPart.tsx
index a6982f1e..3dc5f275 100644
--- a/src/pages/parts/settings/CaptionsPart.tsx
+++ b/src/pages/parts/settings/CaptionsPart.tsx
@@ -116,7 +116,7 @@ export function CaptionsPart(props: {
       backgroundBlur: 0.5,
       backgroundBlurEnabled: !isFirefox,
       bold: false,
-      verticalPosition: 3,
+      verticalPosition: 1,
       fontStyle: "default",
       borderThickness: 1,
     });
@@ -327,23 +327,6 @@ export function CaptionsPart(props: {
                   {t("settings.subtitles.verticalPositionLabel")}
                 </Menu.FieldTitle>
                 <div className="flex justify-center items-center space-x-2">
-                  <button
-                    type="button"
-                    className={classNames(
-                      "px-3 py-1 rounded transition-colors duration-100",
-                      props.styling.verticalPosition === 3
-                        ? "bg-video-context-buttonFocus"
-                        : "bg-video-context-buttonFocus bg-opacity-0 hover:bg-opacity-50",
-                    )}
-                    onClick={() =>
-                      handleStylingChange({
-                        ...props.styling,
-                        verticalPosition: 3,
-                      })
-                    }
-                  >
-                    {t("settings.subtitles.default")}
-                  </button>
                   <button
                     type="button"
                     className={classNames(
@@ -361,6 +344,23 @@ export function CaptionsPart(props: {
                   >
                     {t("settings.subtitles.low")}
                   </button>
+                  <button
+                    type="button"
+                    className={classNames(
+                      "px-3 py-1 rounded transition-colors duration-100",
+                      props.styling.verticalPosition === 3
+                        ? "bg-video-context-buttonFocus"
+                        : "bg-video-context-buttonFocus bg-opacity-0 hover:bg-opacity-50",
+                    )}
+                    onClick={() =>
+                      handleStylingChange({
+                        ...props.styling,
+                        verticalPosition: 3,
+                      })
+                    }
+                  >
+                    {t("settings.subtitles.high")}
+                  </button>
                 </div>
               </div>
               <Button
diff --git a/src/stores/subtitles/index.ts b/src/stores/subtitles/index.ts
index 2efdc60b..81a3884e 100644
--- a/src/stores/subtitles/index.ts
+++ b/src/stores/subtitles/index.ts
@@ -94,7 +94,7 @@ export const useSubtitleStore = create(
         backgroundBlur: 0.5,
         backgroundBlurEnabled: !isFirefox,
         bold: false,
-        verticalPosition: 3,
+        verticalPosition: 1,
         fontStyle: "default",
         borderThickness: 1,
       },
@@ -147,7 +147,7 @@ export const useSubtitleStore = create(
             backgroundBlur: 0.5,
             backgroundBlurEnabled: !isFirefox,
             bold: false,
-            verticalPosition: 3,
+            verticalPosition: 1,
             fontStyle: "default",
             borderThickness: 1,
           };