From 2b30c8e458de9867c0b7c4e2b59e9bf74f8d7da6 Mon Sep 17 00:00:00 2001 From: Sipherdrakon <64430430+Sipherdrakon@users.noreply.github.com> Date: Sun, 31 Aug 2025 18:27:56 -0400 Subject: [PATCH 1/2] Add undetermined audio to list of selections Figured this would be a better option and doesn't rely on assumptions of what language the undetermined audio really is. It also does not create a fallback to download audio that wasn't requested. --- modules/module.langsData.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/module.langsData.ts b/modules/module.langsData.ts index 33bf048..5e6417a 100644 --- a/modules/module.langsData.ts +++ b/modules/module.langsData.ts @@ -42,6 +42,7 @@ const languages: LanguageItem[] = [ { cr_locale: 'id-ID', locale: 'id-ID', code: 'ind', name: 'Indonesian', language: 'Bahasa Indonesia' }, { cr_locale: 'te-IN', locale: 'te-IN', code: 'tel', name: 'Telugu (India)', language: 'తెలుగు' }, { cr_locale: 'ja-JP', adn_locale: 'ja', ao_locale: 'ja', hd_locale: 'Japanese', locale: 'ja', code: 'jpn', name: 'Japanese' }, + { locale: 'un', code: 'und', name: 'Undetermined', language: 'Undetermined', new_hd_locale: 'und', cr_locale: 'und', adn_locale: 'und', ao_locale: 'und' }, ]; // add en language names @@ -97,7 +98,7 @@ const fixLanguageTag = (tag: string) => { // find lang by cr_locale const findLang = (cr_locale: string) => { const lang = languages.find(l => { return l.cr_locale == cr_locale; }); - return lang ? lang : { cr_locale: 'und', locale: 'un', code: 'und', name: '', language: '' }; + return lang ? lang : languages.find(l => l.code === 'und') || { cr_locale: 'und', locale: 'un', code: 'und', name: 'Undetermined', language: 'Undetermined' }; }; const fixAndFindCrLC = (cr_locale: string) => { From 03ab5007d6a4f2d9a3a591488a69b593b8db5a7d Mon Sep 17 00:00:00 2001 From: Sipherdrakon <64430430+Sipherdrakon@users.noreply.github.com> Date: Sun, 31 Aug 2025 19:33:47 -0400 Subject: [PATCH 2/2] revert hidive fallback logic. Again a core change to how all other services work just for hidive doesn't seem like the right course of action. --- hidive.ts | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/hidive.ts b/hidive.ts index 587f5f6..ccde87f 100644 --- a/hidive.ts +++ b/hidive.ts @@ -760,19 +760,8 @@ export default class Hidive implements ServiceClass { } } if (chosenAudios.length == 0) { - console.warn(`Chosen audio language(s) does not exist for episode ${selectedEpisode.episodeInformation.episodeNumber}, falling back to first available audio`); - if (audios.length > 0) { - let chosenAudioQuality = options.q === 0 ? audios.length : options.q; - if(chosenAudioQuality > audios.length) { - chosenAudioQuality = audios.length; - } - chosenAudioQuality--; - chosenAudios.push(audios[chosenAudioQuality]); - console.info(`Using audio track: ${audios[chosenAudioQuality].language.code || 'unknown'}`); - } else { - console.error(`No audio tracks available for episode ${selectedEpisode.episodeInformation.episodeNumber}`); - return undefined; - } + console.error(`Chosen audio language(s) does not exist for episode ${selectedEpisode.episodeInformation.episodeNumber}`); + return undefined; } const fileName = parseFileName(options.fileName, variables, options.numbers, options.override).join(path.sep);