Creepso/multi-downloader-nx
1
0
Fork 0
Code Issues 38 Pull requests 10 Projects Releases 70 Packages Wiki Activity Actions

[HiDive] Remove unreleased episodes from list #685

Merged
Denoder merged 4 commits from patch-1 into master 2024-05-21 14:28:06 +00:00
Conversation 6 Commits 4 Files changed 1 +9 -3
Denoder commented 2024-05-09 21:28:17 +00:00 (Migrated from github.com)
Copy link

When doing a range download/single selection of an anime that's currently airing episodes that haven't released will still get downloaded at 0 bytes. This will skip them if they have a date range in them, rather than an appropriate title.

When doing a range download/single selection of an anime that's currently airing episodes that haven't released will still get downloaded at 0 bytes. This will skip them if they have a date range in them, rather than an appropriate title.
AnimeDL commented 2024-05-18 00:01:09 +00:00 (Migrated from github.com)
Copy link

I apologize for taking so long for getting to review this, I was quite busy on another one of my projects, the change LGTM and appears to work. I am curious on your thoughts though, should it still list it in the output, and just ignore those episodes if requested instead (could be done by just not pushing those episodes to the array)? Incase anybody wants to know when the next episodes come out

I apologize for taking so long for getting to review this, I was quite busy on another one of my projects, the change LGTM and appears to work. I am curious on your thoughts though, should it still list it in the output, and just ignore those episodes if requested instead (could be done by just not pushing those episodes to the array)? Incase anybody wants to know when the next episodes come out
Denoder commented 2024-05-18 21:12:32 +00:00 (Migrated from github.com)
Copy link

Yea i think that'll work

Yea i think that'll work
AnimeDL commented 2024-05-21 03:04:38 +00:00 (Migrated from github.com)
Copy link

I could be crazy, but I think that this has broken downloading on hidive now. Season ID 22309, can't seem to download from it. No episodes end up getting pushed to the array I think

I could be crazy, but I think that this has broken downloading on hidive now. Season ID 22309, can't seem to download from it. No episodes end up getting pushed to the array I think
Denoder commented 2024-05-21 07:47:47 +00:00 (Migrated from github.com)
Copy link

im not having this issue:

im not having this issue: ![](https://i.imgur.com/RMxmBIV.png) ![](https://i.imgur.com/PDvY7Y1.png)
Denoder commented 2024-05-21 07:56:35 +00:00 (Migrated from github.com)
Copy link

Okay i saw my own mistake, try now.

Okay i saw my own mistake, try now.
AnimeDL commented 2024-05-21 14:27:16 +00:00 (Migrated from github.com)
Copy link

Yup, that fixed it. I think it's good to merge now

Yup, that fixed it. I think it's good to merge now
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Wrong-Place

This is the wrong place to write this

  
bug

Something isn't working

  
cli

Used for CLI problems

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
ice

This issue is currently on ice. It may be worked on in the feature, but not in the near future

  
invalid

This doesn't seem right

  
question

Further information is requested

  
request

Used this if you want to request e.g. a feature

  
wontfix

This will not be worked on

No labels
Wrong-Place
bug
cli
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
ice
invalid
question
request
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Creepso/multi-downloader-nx#685
No description provided.
Delete branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?