Fix an issue that SRT time format is incorrect #51

Merged
subdiox merged 1 commit from master into master 2021-05-02 11:15:08 +00:00
subdiox commented 2021-04-08 17:59:25 +00:00 (Migrated from github.com)

On the 4.7.0 update of funimation-downloader-nx, the vttconvert module is added.
However, it has a bug that SRT time format is not processed correctly. Here is the example of it:

83
00:05:08.125 --> 00:05:12.000
WHOSE FAULT THIS IS! -
HERE! LET'S SEE.

84
00:05:12.083 --> 00:05:14.250
ACCORDING TO THE LEDGER
THAT I'VE BEEN KEEPING,

85
00:05:14.333 --> 00:05:16.833
AS OF TODAY,
THE SECURITY COMMITTEE'S

As you can see, the separator between milliseconds and seconds is a period, but official SRT format defines it as a comma.
I have fixed this problem without changing except for a line of code.

On the 4.7.0 update of funimation-downloader-nx, the `vttconvert` module is added. However, it has a bug that SRT time format is not processed correctly. Here is the example of it: ``` 83 00:05:08.125 --> 00:05:12.000 WHOSE FAULT THIS IS! - HERE! LET'S SEE. 84 00:05:12.083 --> 00:05:14.250 ACCORDING TO THE LEDGER THAT I'VE BEEN KEEPING, 85 00:05:14.333 --> 00:05:16.833 AS OF TODAY, THE SECURITY COMMITTEE'S ``` As you can see, the separator between milliseconds and seconds is a period, but official SRT format defines it as a comma. I have fixed this problem without changing except for a line of code.
Sign in to join this conversation.
No description provided.