Creepso/multi-downloader-nx
1
0
Fork 0
Code Issues 38 Pull requests 10 Projects Releases 70 Packages Wiki Activity Actions

[Feedback]: Add Https server support #485

New issue
Open
opened 2023-05-08 18:14:10 +00:00 by crackerbad · 6 comments
crackerbad commented 2023-05-08 18:14:10 +00:00 (Migrated from github.com)
Copy link

Type

GUI

Suggestion

When I access the server using the cloudflare tunnel I get errors on the websocket because the server uses http and cloudflare argo uses https. The only way to access the webinterface is to disable the browser's security settings, with the implementation of wss this would be resolved.

### Type GUI ### Suggestion When I access the server using the cloudflare tunnel I get errors on the websocket because the server uses http and cloudflare argo uses https. The only way to access the webinterface is to disable the browser's security settings, with the implementation of wss this would be resolved.
crackerbad commented 2024-04-23 01:28:01 +00:00 (Migrated from github.com)
Copy link

Until v4.6.3 I was able to use wss by making a small modification to the file gui/server/build/static/js/main.*.js but with the new version of the GUI now I am no longer able to do so.

Until v4.6.3 I was able to use wss by making a small modification to the file ```gui/server/build/static/js/main.*.js``` but with the new version of the GUI now I am no longer able to do so.
AnimeDL commented 2024-04-23 01:36:29 +00:00 (Migrated from github.com)
Copy link

Until v4.6.3 I was able to use wss by making a small modification to the file gui/server/build/static/js/main.*.js but with the new version of the GUI now I am no longer able to do so.

That makes sense, I completely redid the build process, it's now under gui/server/react/build/index.js, just search for ws://... though I'm surprised we haven't implemented this yet

> Until v4.6.3 I was able to use wss by making a small modification to the file `gui/server/build/static/js/main.*.js` but with the new version of the GUI now I am no longer able to do so. That makes sense, I completely redid the build process, it's now under `gui/server/react/build/index.js`, just search for `ws://`... though I'm surprised we haven't implemented this yet
AnimeDL commented 2024-04-23 01:40:56 +00:00 (Migrated from github.com)
Copy link

theoretically, fixing this should be as simple as changing the connection to be ${location.protocol == 'https:' ? 'wss' : 'ws'} instead of explicitly telling it ws

theoretically, fixing this should be as simple as changing the connection to be `${location.protocol == 'https:' ? 'wss' : 'ws'}` instead of explicitly telling it ws
AnimeDL commented 2024-04-23 21:40:19 +00:00 (Migrated from github.com)
Copy link

Implemented in 773bbf034c, let me know if it works for you.

Implemented in 773bbf034ccd2fddd897c0603a67c3580c93ffb2, let me know if it works for you.
crackerbad commented 2024-04-25 21:43:12 +00:00 (Migrated from github.com)
Copy link

Implemented in 773bbf0, let me know if it works for you.

I compiled a build with this update and it worked. thank you very much.

> Implemented in [773bbf0](https://github.com/anidl/multi-downloader-nx/commit/773bbf034ccd2fddd897c0603a67c3580c93ffb2), let me know if it works for you. I compiled a build with this update and it worked. thank you very much.
abaurens commented 2024-04-26 15:36:29 +00:00 (Migrated from github.com)
Copy link

Same here. I just installed it on my self hosted server and it works like a charm 👍

Same here. I just installed it on my self hosted server and it works like a charm 👍
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
syncV3
dependabot/npm_and_yarn/types/node-22.5.5
dependabot/npm_and_yarn/gui/react/micromatch-4.0.8
dependabot/npm_and_yarn/micromatch-4.0.8
dependabot/npm_and_yarn/gui/react/webpack-5.94.0
guiv3
dependabot/npm_and_yarn/leven-4.0.0
dependabot/npm_and_yarn/braces-3.0.3
dependabot/npm_and_yarn/gui/react/braces-3.0.3
multi-download
dependabot/npm_and_yarn/babel/traverse-7.24.1
dependabot/npm_and_yarn/open-10.1.0
native-mp4decrypt
sync
v5.1.5
v5.1.4
v5.1.3
v5.1.2
v5.1.1
v5.1.0
v5.0.3
v5.0.2
v5.0.1
v5.0.0
v4.7.1
v4.7.0
v4.6.3
v4.6.2
v4.6.1
v4.6.0
v4.5.2
v4.5.1
4.5.0-rc1
4.4.3
4.4.1
4.4.0
4.3.0
4.2.0
4.1.0
4.0.3
4.0.2
4.0.1
4.0.0
3.4.4
3.4.0
3.3.6
3.3.5
3.3.4
3.3.3
3.3.2
3.3.1
3.3.0
3.2.0
3.1.0
0.0.1
3.0.7
3.0.6
3.0.5
3.0.4
3.0.3
3.0.2
3.0.1
3.0.0
0.0.0
2.0.18
2.0.17
2.0.16
2.0.15
2.0.14
2.0.13
2.0.12
2.0.11
2.0.10
2.0.9
2.0.8
2.0.6
2.0.5
2.0.4
2.0.3
2.0.2
2.0.1
2.0.0
1.1.1
1.1.0
1.0.4
1.0.3
1.0.2
1.0.1
1.0.0
Labels
Clear labels   
Wrong-Place

This is the wrong place to write this

  
bug

Something isn't working

  
cli

Used for CLI problems

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
ice

This issue is currently on ice. It may be worked on in the feature, but not in the near future

  
invalid

This doesn't seem right

  
question

Further information is requested

  
request

Used this if you want to request e.g. a feature

  
wontfix

This will not be worked on

No labels
Wrong-Place
bug
cli
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
ice
invalid
question
request
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Creepso/multi-downloader-nx#485
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?