Ability to reduce unnecessary bandwidth usage #381

Merged

RavensRain merged 3 commits from master into master

2022-09-19 03:37:53 +00:00

RavensRain commented

2022-09-11 09:12:18 +00:00

(Migrated from github.com)

Added the dlVideoOnce option that automatically downloads the best video quality only once and then downloads the worst available video quality with the same audio quality if multiple languages are selected.
This is achieved by comparing the codecs, because if the codecs are the same, the quality will be the same.

Added the dlVideoOnce option that automatically downloads the best video quality only once and then downloads the worst available video quality with the same audio quality if multiple languages are selected. This is achieved by comparing the codecs, because if the codecs are the same, the quality will be the same.

RavensRain commented

2022-09-11 09:16:02 +00:00

(Migrated from github.com)

I see now that I forgot to remove console.log inside the while loop.

AnidlSupport (Migrated from github.com) requested changes 2022-09-11 10:37:23 +00:00

AnidlSupport (Migrated from github.com) left a comment

The console.logs should be removed.

Also we should Test that the feature works on every situation before setting it as default.
Therefor some tests on our end are required.

However thanks a lot for your contribution.

The `console.log`s should be removed. Also we should Test that the feature works on every situation before setting it as default. Therefor some tests on our end are required. However thanks a lot for your contribution.

AnimeDL (Migrated from github.com) approved these changes 2022-09-12 02:05:27 +00:00

AnimeDL (Migrated from github.com) left a comment

Looks good to me, though I did notice the argument is marked for both, though only actually affects crunchy

AnidlSupport (Migrated from github.com) approved these changes 2022-09-13 06:23:35 +00:00

AnidlSupport (Migrated from github.com) left a comment

LGTM