[BUG] [Funimation] Closed Caption Subtitles #198
Labels
No labels
Wrong-Place
bug
cli
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
ice
invalid
question
request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Creepso/multi-downloader-nx#198
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Program version
2.0.12
Service
Funimation
Command used
node .\index.js --service funi -s 917138 --all --dubLang jpn eng --dlsubs all
Show ID
All
Episode
All
Console Output
Additional Information
English Closed Caption Subtitles should be differentiated from Normal English subtitles, Funimation has 2 versions of English Subtitles for videos that have both English and Japanese dub, Japanese has the normal subtitles, however if you are watching the English version, it yields the CC subtitles. This has resulted in everything I download from Funimation where I download both English and Japanese audio, to always download the CC version of the subtitles instead. My suggested solution to this is to download both versions of the English subtitles when both audio sources are requested, one labeled as Closed Captions. Alternatively as a hotfix, perhaps always prefer the subtitles that come with the Japanese audio if multiple audio sources are requested?
Agreed. It should differentiate and download both.
Fixed with the newest commit.