From 0f83899bac724fe8806021eb64bc1121365a1793 Mon Sep 17 00:00:00 2001 From: NBA2K1 <78034913+NBA2K1@users.noreply.github.com> Date: Wed, 17 Dec 2025 21:34:45 +0100 Subject: [PATCH] remove unnecessary calls .trimLeft().trimRight() after trim() is unnecessary. --- lib/eval/model/m_bridge.dart | 8 +++----- .../manga/download/providers/download_provider.dart | 4 ++-- lib/modules/widgets/manga_image_card_widget.dart | 2 +- lib/utils/extensions/dom_extensions.dart | 4 ++-- lib/utils/extensions/others.dart | 2 +- lib/utils/html_to_xml_doc.dart | 2 +- 6 files changed, 10 insertions(+), 12 deletions(-) diff --git a/lib/eval/model/m_bridge.dart b/lib/eval/model/m_bridge.dart index c942940a..1bd98ede 100644 --- a/lib/eval/model/m_bridge.dart +++ b/lib/eval/model/m_bridge.dart @@ -75,14 +75,12 @@ class MBridge { var query = htmlXPath.query(xpath); if (query.nodes.length > 1) { for (var element in query.attrs) { - attrs.add(element!.trim().trimLeft().trimRight()); + attrs.add(element!.trim()); } } //Return one attr else if (query.nodes.length == 1) { - String attr = query.attr != null - ? query.attr!.trim().trimLeft().trimRight() - : ""; + String attr = query.attr != null ? query.attr!.trim() : ""; if (attr.isNotEmpty) { attrs = [attr]; } @@ -102,7 +100,7 @@ class MBridge { statusMap = element; for (var element in statusMap.entries) { if (element.key.toString().toLowerCase().contains( - status.toLowerCase().trim().trimLeft().trimRight(), + status.toLowerCase().trim(), )) { return switch (element.value as int) { 0 => Status.ongoing, diff --git a/lib/modules/manga/download/providers/download_provider.dart b/lib/modules/manga/download/providers/download_provider.dart index 84779510..66e4037b 100644 --- a/lib/modules/manga/download/providers/download_provider.dart +++ b/lib/modules/manga/download/providers/download_provider.dart @@ -309,7 +309,7 @@ Future downloadChapter( if (!file.existsSync()) { pages.add( PageUrl( - page.url.trim().trimLeft().trimRight(), + page.url.trim(), headers: pageHeaders, fileName: p.join( chapterDirectory.path, @@ -325,7 +325,7 @@ Future downloadChapter( if (!file.existsSync()) { pages.add( PageUrl( - page.url.trim().trimLeft().trimRight(), + page.url.trim(), headers: pageHeaders, fileName: p.join(mangaMainDirectory.path, "$chapterName.mp4"), ), diff --git a/lib/modules/widgets/manga_image_card_widget.dart b/lib/modules/widgets/manga_image_card_widget.dart index 0f34f4dc..cfd11afe 100644 --- a/lib/modules/widgets/manga_image_card_widget.dart +++ b/lib/modules/widgets/manga_image_card_widget.dart @@ -342,7 +342,7 @@ Future pushToMangaReaderDetail({ mangaM ?? Manga( imageUrl: getManga!.imageUrl, - name: getManga.name!.trim().trimLeft().trimRight(), + name: getManga.name!.trim(), genre: getManga.genre?.map((e) => e.toString()).toList() ?? [], author: getManga.author ?? "", status: getManga.status ?? Status.unknown, diff --git a/lib/utils/extensions/dom_extensions.dart b/lib/utils/extensions/dom_extensions.dart index b7d3b3ba..6a8da35e 100644 --- a/lib/utils/extensions/dom_extensions.dart +++ b/lib/utils/extensions/dom_extensions.dart @@ -326,7 +326,7 @@ extension DocumentExtension on Document? { var htmlXPath = HtmlXPath.node(dom); var query = htmlXPath.query(xpath); if (query.nodes.length > 1) { - return query.attrs.map((e) => e!.trim().trimLeft().trimRight()).toList(); + return query.attrs.map((e) => e!.trim()).toList(); } return []; } @@ -365,7 +365,7 @@ extension ElementtExtension on Element { var htmlXPath = HtmlXPath.node(this); var query = htmlXPath.query(xpath); if (query.nodes.length > 1) { - return query.attrs.map((e) => e!.trim().trimLeft().trimRight()).toList(); + return query.attrs.map((e) => e!.trim()).toList(); } return []; } diff --git a/lib/utils/extensions/others.dart b/lib/utils/extensions/others.dart index c281c731..b10123fe 100644 --- a/lib/utils/extensions/others.dart +++ b/lib/utils/extensions/others.dart @@ -125,7 +125,7 @@ extension UChapDataPreloadExtensions on UChapDataPreload { ), ) : CustomExtendedNetworkImageProvider( - data.pageUrl!.url.trim().trimLeft().trimRight(), + data.pageUrl!.url.trim(), cache: true, cacheMaxAge: const Duration(days: 7), showCloudFlareError: showCloudFlareError, diff --git a/lib/utils/html_to_xml_doc.dart b/lib/utils/html_to_xml_doc.dart index 3199c03a..18c1c52f 100644 --- a/lib/utils/html_to_xml_doc.dart +++ b/lib/utils/html_to_xml_doc.dart @@ -61,7 +61,7 @@ // var query = xpath(expression); // if (query.isNotEmpty) { // return query -// .map((e) => (e.value ?? "").trim().trimLeft().trimRight()) +// .map((e) => (e.value ?? "").trim()) // .toList(); // } // } catch (_) {}