Exception in MangaClash listing: RangeError (invalid indexing) #36

New issue

Closed

opened 2024-03-11 21:10:35 +00:00 by resolritter · 0 comments

resolritter commented

2024-03-11 21:10:35 +00:00

(Migrated from github.com)

Source information

MangaClash 0.0.85

Source language

English

Steps to reproduce

Install the MangaClash extension v0.0.85
Open up a listing in the app which cannot be processed correctly (see the screenshot below)

Expected behavior

The listings' chapters are loaded successfully

Actual behavior

An exception is thrown while loading the listing's chapters:

Mangayomi version

0.1.85

Device

Samsung Galaxy Tab A

Other details

This problem seems to happen because the madara source adds to 3 arrays independently in getDetail: chapUrls, chaptersNames and chapDates.

1e6f245175/manga/multisrc/madara/madara.dart (L184-L186)

If those arrays somehow end up with different sizes, then an exception might be thrown later on due to incorrect indexing, presumably around here:

1e6f245175/manga/multisrc/madara/madara.dart (L242)

I have refactored that part of the code locally and the problem apparently went away. I'll submit a PR for this later.

Acknowledgements

I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
I have written a short but informative title.
I have updated all installed extensions.
If this is an issue with the app itself, I should be opening an issue in the app repository.

### Source information MangaClash 0.0.85 ### Source language English ### Steps to reproduce 1. Install the MangaClash extension v0.0.85 2. Open up a listing in the app which cannot be processed correctly (see the screenshot below) ### Expected behavior The listings' chapters are loaded successfully ### Actual behavior An exception is thrown while loading the listing's chapters: ![Screenshot_20240311-001614](https://github.com/kodjodevf/mangayomi-extensions/assets/17429390/46942443-3e81-4ae6-8c0a-393c752f0f40) ### Mangayomi version 0.1.85 ### Device Samsung Galaxy Tab A ### Other details This problem seems to happen because the `madara` source adds to 3 arrays independently in `getDetail`: `chapUrls`, `chaptersNames` and `chapDates`. https://github.com/kodjodevf/mangayomi-extensions/blob/1e6f245175e5716abcce9c10c48de79d3584c59a/manga/multisrc/madara/madara.dart#L184-L186 If those arrays somehow end up with different sizes, then an exception might be thrown later on due to incorrect indexing, presumably around here: https://github.com/kodjodevf/mangayomi-extensions/blob/1e6f245175e5716abcce9c10c48de79d3584c59a/manga/multisrc/madara/madara.dart#L242 I have refactored that part of the code locally and the problem apparently went away. I'll submit a PR for this later. ### Acknowledgements - [X] I have searched the existing issues and this is a new ticket, **NOT** a duplicate or related to another open or closed issue. - [X] I have written a short but informative title. - [X] I have updated all installed extensions. - [X] If this is an issue with the app itself, I should be opening an issue in the [app repository](https://github.com/kodjodevf/mangayomi/issues/new/choose).