Contribution Changes #39

Merged

arichornlover merged 4 commits from main into main 2023-09-17 08:10:11 +00:00

Conversation 17 Commits 4 Files changed 5 +268 -320

arichornlover commented 2023-09-17 02:18:51 +00:00 (Migrated from github.com)

Copy link

I have contributed on this tweak. I added a ton of new options and then removed an option called “Disable WiFi Related Settings” since it was replaced and then updated the Version Spoofer (Lite) and made the localization better for you 👍

I have contributed on this tweak. I added a ton of new options and then removed an option called “Disable WiFi Related Settings” since it was replaced and then updated the Version Spoofer (Lite) and made the localization better for you 👍

arichornlover commented 2023-09-17 03:08:34 +00:00 (Migrated from github.com)

Copy link

Also you can expand those options from my pull request if you want to. I added images above that I used to make those options 😁

   Also you can expand those options from my pull request if you want to. I added images above that I used to make those options 😁

Balackburn commented 2023-09-17 08:12:05 +00:00 (Migrated from github.com)

Copy link

Thanks you a lot for all this work,I saw you made these changes in your uyouplusextra repo but I didn't had the courage to add them myself, it's merged

Thanks you a lot for all this work,I saw you made these changes in your uyouplusextra repo but I didn't had the courage to add them myself, it's merged

arichornlover commented 2023-09-17 08:20:57 +00:00 (Migrated from github.com)

Copy link

Well I was gonna add more sections since I recently implemented new ones on YouTubeRebornPlus because YouTube rolled out a new tab in the pivot bar which changed everything about the app including the sections so I changed a ton of stuff 😭
ded44ef5d9
Also can you give me Collaborators Access to the repo so I can easily add the newer changes?

Well I was gonna add more sections since I recently implemented new ones on YouTubeRebornPlus because YouTube rolled out a new tab in the pivot bar which changed everything about the app including the sections so I changed a ton of stuff 😭 https://github.com/arichorn/YouTubeRebornPlus/commit/ded44ef5d9730c20271d1595a0c4e83f436f81a1 Also can you give me Collaborators Access to the repo so I can easily add the newer changes?

Balackburn commented 2023-09-17 09:37:30 +00:00 (Migrated from github.com)

Copy link

@arichorn I sent you an invitation

@arichorn I sent you an invitation

arichornlover commented 2023-09-17 20:13:25 +00:00 (Migrated from github.com)

Copy link

Also if you didn’t notice I removed the Disable Wi-Fi Related Settings Option in addition to the App Settings Overlay Options Stuff in case you didn’t know 👍

Also if you didn’t notice I removed the `Disable Wi-Fi Related Settings` Option in addition to the `App Settings Overlay Options` Stuff in case you didn’t know 👍

Balackburn commented 2023-09-17 20:20:40 +00:00 (Migrated from github.com)

Copy link

@arichorn I built an .ipa but hadn't installed it because Sidestore is not working for me today, so I didn't saw.
Thanks for the info

@arichorn I built an .ipa but hadn't installed it because Sidestore is not working for me today, so I didn't saw. Thanks for the info

arichornlover commented 2023-09-18 00:27:51 +00:00 (Migrated from github.com)

Copy link

Here it is! It works as intended!

but there is a problem with 3 of the options DontEatMyContent, Return YouTube Dislike & YouPiP and I’m not sure if there is a way to hide them since the ose sections do not hide like all of the others.

Here it is! It works as intended!  but there is a problem with 3 of the options DontEatMyContent, Return YouTube Dislike & YouPiP and I’m not sure if there is a way to hide them since the ose sections do not hide like all of the others.

Balackburn commented 2023-10-05 17:23:14 +00:00 (Migrated from github.com)

Copy link

@arichorn their is a problem with the new localizations APP_SETTINGS_OVERLAY_OPTIONS and APP_VERSION_SPOOFER_LITE aren't changed correctly see here :

@arichorn their is a problem with the new localizations APP_SETTINGS_OVERLAY_OPTIONS and APP_VERSION_SPOOFER_LITE aren't changed correctly see here :  

arichornlover commented 2023-10-05 21:02:42 +00:00 (Migrated from github.com)

Copy link

Alright fixed it 👍

Alright fixed it 👍

Balackburn commented 2023-10-05 21:57:48 +00:00 (Migrated from github.com)

Copy link

@arichorn Only one of the two APP_VERSION_SPOOFER_LITE still appear like this :

@arichorn Only one of the two APP_VERSION_SPOOFER_LITE still appear like this : 

arichornlover commented 2023-10-06 00:07:15 +00:00 (Migrated from github.com)

Copy link

I didn’t add the LOC() in the option, that would explain why it wasn’t working, but it works now hopefully 🤞

I didn’t add the LOC() in the option, that would explain why it wasn’t working, but it works now hopefully 🤞

Balackburn commented 2023-10-06 10:46:38 +00:00 (Migrated from github.com)

Copy link

@arichorn Thx it worked

@arichorn Thx it worked

arichornlover commented 2023-11-27 05:29:49 +00:00 (Migrated from github.com)

Copy link

I was gonna do another commit that includes 5 new options to YTLitePlus but then I realized that these will have noticeable gaps between the buttons which will be annoying to see in the video player.

// Hide the (Remix / Thanks / Download / Clip / Save) Buttons under the Video Player - @arichorn
%hook _ASDisplayView
- (void)layoutSubviews {
    %orig;
    BOOL hideRemixButton = IsEnabled(@"hideRemixButton_enabled");
    BOOL hideThanksButton = IsEnabled(@"hideThanksButton_enabled");
    BOOL hideAddToOfflineButton = IsEnabled(@"hideAddToOfflineButton_enabled");
    BOOL hideClipButton = IsEnabled(@"hideClipButton_enabled");
    BOOL hideSaveToPlaylistButton = IsEnabled(@"hideSaveToPlaylistButton_enabled");

    for (UIView *subview in self.subviews) {
        if ([subview.accessibilityIdentifier isEqualToString:@"id.video.remix.button"]) {
            subview.hidden = hideRemixButton;
        } else if ([subview.accessibilityLabel isEqualToString:@"Thanks"]) {
            subview.hidden = hideThanksButton;
        } else if ([subview.accessibilityIdentifier isEqualToString:@"id.ui.add_to.offline.button"]) {
            subview.hidden = hideAddToOfflineButton;
        } else if ([subview.accessibilityLabel isEqualToString:@"Clip"]) {
            subview.hidden = hideClipButton;
        } else if ([subview.accessibilityLabel isEqualToString:@"Save to playlist"]) {
            subview.hidden = hideSaveToPlaylistButton;
        }
    }
}
%end

I was gonna do another commit that includes 5 new options to YTLitePlus but then I realized that these will have noticeable gaps between the buttons which will be annoying to see in the video player. ``` // Hide the (Remix / Thanks / Download / Clip / Save) Buttons under the Video Player - @arichorn %hook _ASDisplayView - (void)layoutSubviews { %orig; BOOL hideRemixButton = IsEnabled(@"hideRemixButton_enabled"); BOOL hideThanksButton = IsEnabled(@"hideThanksButton_enabled"); BOOL hideAddToOfflineButton = IsEnabled(@"hideAddToOfflineButton_enabled"); BOOL hideClipButton = IsEnabled(@"hideClipButton_enabled"); BOOL hideSaveToPlaylistButton = IsEnabled(@"hideSaveToPlaylistButton_enabled"); for (UIView *subview in self.subviews) { if ([subview.accessibilityIdentifier isEqualToString:@"id.video.remix.button"]) { subview.hidden = hideRemixButton; } else if ([subview.accessibilityLabel isEqualToString:@"Thanks"]) { subview.hidden = hideThanksButton; } else if ([subview.accessibilityIdentifier isEqualToString:@"id.ui.add_to.offline.button"]) { subview.hidden = hideAddToOfflineButton; } else if ([subview.accessibilityLabel isEqualToString:@"Clip"]) { subview.hidden = hideClipButton; } else if ([subview.accessibilityLabel isEqualToString:@"Save to playlist"]) { subview.hidden = hideSaveToPlaylistButton; } } } %end ```

Balackburn commented 2023-11-28 22:29:35 +00:00 (Migrated from github.com)

Copy link

@arichorn Did you tried the options ?

@arichorn Did you tried the options ?

arichornlover commented 2023-11-28 22:33:19 +00:00 (Migrated from github.com)

Copy link

well. Heres an example of me hiding the Download Button.

 well. Heres an example of me hiding the Download Button.

Balackburn commented 2023-11-28 22:36:22 +00:00 (Migrated from github.com)

Copy link

well. Heres an example of me hiding the Download Button.

Yes it look bad don't add it, does you know how to hide these shorts with latest YT version ?

>  > > > > well. Heres an example of me hiding the Download Button. > > Yes it look bad don't add it, does you know how to hide these shorts with latest YT version ? 

arichornlover commented 2023-11-28 23:06:32 +00:00 (Migrated from github.com)

Copy link

Yes it look bad don't add it, does you know how to hide these shorts with latest YT version ?

Implement this. If you see the code below then it will completely hides shorts, and the best part is there aren’t any gaps. And you it also doesn’t randomly appear and disappear when tapping on it! Which means any where you go in the app, shorts won’t be shown. And for some reason it feels like old YouTube!

%hook YTIElementRenderer
- (NSData *)elementData {
    NSString *description = [self description];
    if ([description containsString:@"shorts_shelf.eml"] || [description containsString:@"#shorts"] || [description containsString:@"shorts_video_cell.eml"] || [description containsString:@"6Shorts"]) {
        if (![description containsString:@"history*"]) {
            return nil;
        }
    }
    return %orig;
}
%end

this tweak was made by PoomSmart and iCrazeiOS
can be found in https://github.com/PoomSmart/YTUnShorts

> Yes it look bad don't add it, does you know how to hide these shorts with latest YT version ? Implement this. If you see the code below then it will completely hides shorts, and the best part is there aren’t any gaps. And you it also doesn’t randomly appear and disappear when tapping on it! Which means any where you go in the app, shorts won’t be shown. And for some reason it feels like old YouTube! ``` %hook YTIElementRenderer - (NSData *)elementData { NSString *description = [self description]; if ([description containsString:@"shorts_shelf.eml"] || [description containsString:@"#shorts"] || [description containsString:@"shorts_video_cell.eml"] || [description containsString:@"6Shorts"]) { if (![description containsString:@"history*"]) { return nil; } } return %orig; } %end ``` this tweak was made by PoomSmart and iCrazeiOS can be found in https://github.com/PoomSmart/YTUnShorts

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

YTLite

A bug related to YTLite

  

bug

Something isn't working

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

YTLite

bug

documentation

duplicate

enhancement

good first issue

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Creepso/YTLitePlus#39

No description provided.