Creepso/YTLitePlus
1
0
Fork 0
Code Issues 43 Pull requests Projects Releases 52 Packages Wiki Activity Actions

Switch Submodules #259

Merged
bhackel merged 11 commits from fix-youpip into main 2024-07-21 05:40:13 +00:00
Conversation 8 Commits 11 Files changed 9 +31 -28
bhackel commented 2024-07-19 08:02:32 +00:00 (Migrated from github.com)
Copy link

Hello friends, I was wondering what the reason for the fork of YouPiP was for. I think the constant updating of forks causes bugs to stay for longer than needed. However, if there is a good reason for the fork, then I am open to keeping it. If not, then this pull request changes the submodule to PoomSmart's original version. Thanks

Hello friends, I was wondering what the reason for the fork of YouPiP was for. I think the constant updating of forks causes bugs to stay for longer than needed. However, if there is a good reason for the fork, then I am open to keeping it. If not, then this pull request changes the submodule to PoomSmart's original version. Thanks
arichornloverALT commented 2024-07-19 12:30:08 +00:00 (Migrated from github.com)
Copy link

I modified YouPiP and Return-YouTube-Dislikes

YouPiP (my fork): Includes Fake YouTube Version option but kept it for LowContrastMode.
Return-YouTube-Dislikes (my fork): Includes a new option to switch emojis back to texts (example: “⌛” to “Fetching”)

I modified YouPiP and Return-YouTube-Dislikes YouPiP (my fork): Includes Fake YouTube Version option but kept it for LowContrastMode. Return-YouTube-Dislikes (my fork): Includes a new option to switch emojis back to texts (example: “⌛” to “Fetching”)
arichornloverALT commented 2024-07-19 16:57:14 +00:00 (Migrated from github.com)
Copy link

Nevermind, implementation broke when PoomSmart updated RYD d55a90d3ce

Edit: Fixed it. I updated the code from the repo to work without having any redefinition errors.

Nevermind, implementation broke when PoomSmart updated RYD https://github.com/PoomSmart/Return-YouTube-Dislikes/commit/d55a90d3cebd0913ce7d3b759d2171189d9de604 Edit: Fixed it. I updated the code from the repo to work without having any redefinition errors.
bhackel commented 2024-07-19 17:14:31 +00:00 (Migrated from github.com)
Copy link

Ah Ok sounds good, I will think about what to keep/update later today then

Ah Ok sounds good, I will think about what to keep/update later today then
bhackel commented 2024-07-20 22:03:52 +00:00 (Migrated from github.com)
Copy link

@arichornloverALT I'm wondering how much the YouPiP changes are required for LowContrastMode to work. I've already switched back the RYD tweak. Let me know

@arichornloverALT I'm wondering how much the YouPiP changes are required for LowContrastMode to work. I've already switched back the RYD tweak. Let me know
arichornloverALT commented 2024-07-20 22:14:40 +00:00 (Migrated from github.com)
Copy link

@arichornloverALT I'm wondering how much the YouPiP changes are required for LowContrastMode to work. I've already switched back the RYD tweak. Let me know

The changes is that it re-adds PoomSmart’s Fake YouTube Version code from 6d7f4e73a9
but I modified it to be set to “17.38.10”
this only changes the stuff on the video player.

> @arichornloverALT I'm wondering how much the YouPiP changes are required for LowContrastMode to work. I've already switched back the RYD tweak. Let me know The changes is that it re-adds PoomSmart’s Fake YouTube Version code from https://github.com/PoomSmart/YouPiP/commit/6d7f4e73a97e241bacb89679f0a2866276aa0ff0 but I modified it to be set to “17.38.10” this only changes the stuff on the video player.
bhackel commented 2024-07-21 03:54:24 +00:00 (Migrated from github.com)
Copy link

Ah alright I see that, I am a little confused though, is that code needed to make the PiP work in older versions, or does it simply spoof the version to something older?

Ah alright I see that, I am a little confused though, is that code needed to make the PiP work in older versions, or does it simply spoof the version to something older?
arichornloverALT commented 2024-07-21 05:40:03 +00:00 (Migrated from github.com)
Copy link

does it simply spoof the version to something older?

It spoofs the app (similar to a version spoofer) but instead, it just only spoofs the Video Player Interface and basically is the same thing.
anyways I’ll merge this now. 👍

> does it simply spoof the version to something older? It spoofs the app (similar to a version spoofer) but instead, it just only spoofs the Video Player Interface and basically is the same thing. anyways I’ll merge this now. 👍
bhackel commented 2024-07-21 06:18:35 +00:00 (Migrated from github.com)
Copy link

Ah alright I understand, thank you

Ah alright I understand, thank you
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
YTLite

A bug related to YTLite

  
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
YTLite
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Creepso/YTLitePlus#259
No description provided.
Delete branch "fix-youpip"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?