[Request] Add uYou player gestures (volume, seek, brightness) and in-player Loop button #238
Labels
No labels
YTLite
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Creepso/YTLitePlus#238
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Player gestures controls and Replay button
Some gestures exist, what others? What is replay button, like loop?
The gestures that exist aren't very intuitive. Coming from uYou, it would be nice to have the same gesture layout uYou does, it's pretty much my only request as well.
Top for Volume
Middle for Brightness
Bottom for Seek (Not the native YT seeking where it's tap-hold-drag. Just direct dragging)
One finger dragging for all of them.
Also, I believe by "Replay Button" the OP means a persistent loop button in player controls overlay, just like the "Video Overlay" buttons for quality and muting.
Yes! The volume seek gesture on top area of video player in uyou is beautiful. I felt only that missing, else this is better in all other terms.
@bhackel I wholeheartedly wish the volume, brightness(single finger) gestures can be ported to YTlitePlus, that'd be the only missing piece for me to make it on par with revanced on Android and uYouEnhanced on iOS
Seconding the gestures and player overlays from uYou into YTLite. Recently I was told that YTLite will have more maintenance so I switched from uYou and i do like the simplicity and UI of YTLite, but I really miss the features of uYou especially the player overlays such as speed controls while playing the video
Yes YTLite has speed controls
I know we can control video speed if we click the settings cog icon on the video player, but what I am asking for is similar to uYou where there is separate buttons for the speed right under the play/pause button when you tap the player. Additionally the other features like loop and rotation lock was on the top right of the player under where the current mute/cast/captions/settings options are. I would share a picture but unfortunately I don't have uYou Enhanced anymore because I removed it and switched to YT Lite, and I couldn't find any pictures or videos on YouTube of the feature I'm describing.
Yes I understand, Settings - YouTube Plus - Player - Speed Controls. I will make the loop button in some way, it won’t be the same as uYou though, and will instead be like YouMute and YouQuality. Fullscreen to the right is now a toggle that affects the fullscreen behavior (I’m not sure if it’s broken right now) instead of a button
I can't believe I missed that option and it was the first one too. Thank you for helping me find it.
That's fine anything would be okay as long as it's conveniently placed on the player overlay. Thanks for taking the time to make the feature.
Update, I got volume gesture working. Has some bugs, like preventing other gestures, but it is good progress.
https://github.com/user-attachments/assets/eda574d1-a837-480f-83d8-b45853cc285f
Will you be able to add similar configuration to it, like how uYou has "Sensitivity" and "Speed" configs?
Yes those should be easy to implement as well
Loop Button
Gesture Configuration Options
Will be merging all changes within a few days
Finally!!! 👌👍
Download here: https://github.com/YTLitePlus/YTLitePlus/actions/runs/10467538943
There are a few things that I think are annoying, but if you want to test it now, then go ahead.
Will do.
Functionality wise, it works well, but there are definitely a few tweaks that could be made going forward.
[Bugs]
[Suggestions]
100% appreciate the work that went into this. This is like genuinely useful. Thank you!!! 😁
https://streamable.com/j3xaxr
Pretty much agree with everything you have mentioned.
Another thing I found, you can seek into negative time
https://github.com/user-attachments/assets/7a3756ea-180e-48d3-a70d-3690a83b086a
I’ve done a good amount of changes in this version:
Some bugs I have noticed:
Merging soon
Download here: https://github.com/bhackel/YTLitePlus/actions/runs/10555896693
Awesome! Here's a few other issues I noticed.
(Old, didn't have time to report it earlier), Gestures are still active when engagement overlays are on screen. Video: https://streamable.com/ia7pib
Smoothing/inertia seems to cause the seek bar to continue for a bit in the direction you were dragging, after you stop and go in the opposite direction.
Suggestions:
uYou allows gestures to work in the MiniPlayer, this might of just been an unintentional thing Miro just flew with but if you can swing it without it being a burden that'd be nice.
Put a notice that changes to settings require a restart to apply in the settings page.
Bugs remaining
Thanks for your help with this. Lots of useful feedback, really appreciate it.
This is likely an unintended side effect, the way I worded it might not have gotten it through clearly.
When you stop dragging while still holding the bar, and then seek in the opposite direction the bar will continue to move in the opposing direction than your dragging.
Ex: I drag to the right, then stop (still holding the seek bar), i then drag to the left, the seek bar will continue to move to the right for a short while and then move to the left.
Not exactly sure if it's related to the inertia thats just my guess because that's the kind of effect it seems to give when it's doing this. Maybe the application of inertia gets ignored when you stop dragging while still holding the bar and then gets applied when you drag again hence why it continues in the opposite direction.
Hopefully this helps clarify.
As for this, maybe a solution would be to blacklist Volume, Seek, and Brightness gestures when the suggested videos overlay is present until it's dismissed, and for the sidebar overlay, you can scale the gestures with the viewport so they can only be recognized when swiping over the video and not the overlay?
I believe this is how uYou gets it to work properly and with the MiniPlayer, the gesture recognizers are actually linked to the viewport itself and scale accordingly along with it.
It would appear that this applies to all gestures.
Also, I recently switch back to uYou to do a quick comparison between the implementations and theres a few things I noticed that could use some improvement
With uYou, when seeking, all player overlays are hidden, the only thing visible is the seek bar, absolutely nothing else. This helps to clearly preview the video when dragging. Definitely a needed change. (Video: https://streamable.com/7cu2vt)
The max sensitivity/speed doesnt match uYou's, I think bumping the max range up to 2.5x should do it.
The smoothing could use a bump up by 3%.
One of the reasons why I didn’t copy the seek uYou gesture completely was because their implementation does not pause playback when seeking. This results in sponsor block preventing you from going backwards over sponsored segments.
I can definitely add more sensitivity options.
For smoothing, I’ll probably use a different implementation that does not have as many issues. Will work on it this weekend likely.
To me it appears you're using the native YouTube seeking and just linking a gesture control to it, hence why it works like regularly dragging the seek bar which is why all the overlays appear. Is there no way to simply just hide all HUD elements when gesturing? That would seem like a simple solution while still maintaining the native seeking implementation instead of a custom one like uYou, which should lead to less problems down the line.
Should I be expecting any future updates on this or is development on an indefinite pause?
No they will be updates, it's been a day since last commit, and the latest release is 5 days old.
I think they were referring specifically to this feature since bhackel was seemingly the one dev working on this issue AFAIK (did a quick skim of the commit history and of course he was active in this issue). Since bhackel is taking an indefinite break due to what happened with YouTube Plus, will either you or arichornlover take over hopefully?