Revamped OLED & Old Dark Themes!

arichornlover commented

2023-07-31 12:31:29 +00:00

(Migrated from github.com)

hello Balackburn! I'm putting this here! I think I successfully Implemented the new and improved OLED & old dark theme options! this took me days and at least a ton of effort to get it to work with the app but glad I was happy to help!

arichornlover commented

2023-07-31 12:33:21 +00:00

(Migrated from github.com)

also I removed UIView because I've changed a ton of stuff do not ever put UIView back in Themes.xm. it is no longer needed.

Balackburn commented

2023-07-31 12:33:41 +00:00

(Migrated from github.com)

thx you a lot, could you explain what does it exactly change?

arichornlover commented

2023-07-31 12:37:42 +00:00

(Migrated from github.com)

thx you a lot, could you explain what does it exactly change?

what I changed is:

if you use OLED or old dark theme options and then toggling Light Mode, it should not break anymore in this pull request
I updated YTCommonColorPalette because I'm so stupid for not realizing Google added more Background Colors
I updated the Comments. the Chip Bar background now supports old dark mode & OLED Dark Mode.

Overrall it supports up to the latest YouTube version. I've done a good job this time.

> thx you a lot, could you explain what does it exactly change? what I changed is: - if you use OLED or old dark theme options and then toggling Light Mode, it should not break anymore in this pull request - I updated YTCommonColorPalette because I'm so stupid for not realizing Google added more Background Colors - I updated the Comments. the Chip Bar background now supports old dark mode & OLED Dark Mode. ## Overrall it supports up to the latest YouTube version. I've done a good job this time.

arichornlover commented

2023-07-31 12:41:46 +00:00

(Migrated from github.com)

Also here’s the newest YouTube ipa https://www.dropbox.com/scl/fi/s36vwnozebf6lyumvry0o/YouTube-v18.30.6.ipa?rlkey=mch707905cpr9ev9bcs0sdyu5&dl=1

Balackburn commented

2023-07-31 12:53:43 +00:00

(Migrated from github.com)

@arichorn the new darkmode hide "add a comment..." text in the comment view

arichornlover commented

2023-07-31 12:56:24 +00:00

(Migrated from github.com)

@arichorn the new darkmode hide "add a comment..." text in the comment view

it's alright. it doesn't actually "hide" it, it's still there and it's just invisible for some reason? and also it still functions. I'll find a workaround for that one whenever I find a method for it.

> @arichorn the new darkmode hide "add a comment..." text in the comment view it's alright. it doesn't actually "hide" it, it's still there and it's just invisible for some reason? and also it still functions. I'll find a workaround for that one whenever I find a method for it.

Balackburn commented

2023-07-31 13:02:40 +00:00

(Migrated from github.com)

@arichorn ok, also broke comments like number view

@arichorn ok, also broke comments like number view ![IMG_2781](https://github.com/Balackburn/YTLitePlus/assets/93828569/d3e4bf5a-32ff-40c6-b224-c0960298c1ae)

arichornlover commented

2023-07-31 13:06:11 +00:00

(Migrated from github.com)

@arichornok, also broke comments like number view

I know what it is. I'll do another pr and remove it. but whatever I'll change may remove the ability to change the chip bar's color in the comment section.

> @arichornok, also broke comments like number view ![IMG_2781](https://user-images.githubusercontent.com/93828569/257227642-d3e4bf5a-32ff-40c6-b224-c0960298c1ae.jpg) I know what it is. I'll do another pr and remove it. but whatever I'll change may remove the ability to change the chip bar's color in the comment section.

Revamped OLED & Old Dark Themes! #23

Overrall it supports up to the latest YouTube version. I've done a good job this time.