[Bug] (iPad) youtube-native-share doesn’t work when using on an iPad or when using iPad layout #165

New issue

Closed

opened 2024-06-03 21:45:54 +00:00 by Macleykun · 19 comments

Macleykun commented 2024-06-03 21:45:54 +00:00 (Migrated from github.com)

Copy link

Is there an existing issue for this?

• I have searched the existing issues

Have you read the FAQ?

• Yes, I read the FAQ

Device info

• iOS/iPadOS version: 17.5.1
• Device model: iPad 9th gen
• Sideload tool (AltStore, Sideloadly, TrollStore,...): side store
• The specific version of YTLitePlus (latest or newest is NOT a version number!): v19.21.3-4.0

Describe the bug

The youtube-native-share doesn’t work
See: https://github.com/jkhsjdhjs/youtube-native-share?tab=readme-ov-file#what
If you toggle this tweak on/off it doesn’t change the style sheet.

Steps to reproduce the issue

1. Navigate in YouTube Plus to interface.
2. In interface toggle Native share sheet ON.
3. Restart the app to be sure.
4. Observe no difference.

Crash log (if the app crashes)

No response

Are you using the newest version of YTLitePlus? If not, why?

✅ Yes, I'm using the latest version of YTLitePlus right now

Does the issue happen with the official YouTube from AppStore?

❌ No, It doesn't

Additional context

### Is there an existing issue for this? - [X] I have searched the existing issues ### Have you read the FAQ? - [X] Yes, I read the FAQ ### Device info - iOS/iPadOS version: 17.5.1 - Device model: iPad 9th gen - Sideload tool (AltStore, Sideloadly, TrollStore,...): side store - The specific version of YTLitePlus (**latest** or **newest** is **NOT** a version number!): v19.21.3-4.0 ### Describe the bug The [youtube-native-share](https://github.com/jkhsjdhjs/youtube-native-share) doesn’t work See: https://github.com/jkhsjdhjs/youtube-native-share?tab=readme-ov-file#what If you toggle this tweak on/off it doesn’t change the style sheet. ### Steps to reproduce the issue 1. Navigate in YouTube Plus to interface. 2. In interface toggle Native share sheet ON. 3. Restart the app to be sure. 4. Observe no difference. ### Crash log (if the app crashes) _No response_ ### Are you using the newest version of YTLitePlus? If not, why? ✅ Yes, I'm using the latest version of YTLitePlus right now ### Does the issue happen with the official YouTube from AppStore? ❌ No, It doesn't ### Additional context   

arichornlover commented 2024-06-11 00:21:16 +00:00 (Migrated from github.com)

Copy link

Same, but it does work on iPhones. (I used iPhone Layout from YTLitePlus Settings)

so I am assuming it might be incompatible with iPad Devices which is odd?

Same, but it does work on iPhones. (I used **iPhone Layout** from YTLitePlus Settings) so I am assuming it might be incompatible with iPad Devices which is odd?

Macleykun commented 2024-06-11 11:53:06 +00:00 (Migrated from github.com)

Copy link

Same, but it does work on iPhones. (I used iPhone Layout from YTLitePlus Settings)

so I am assuming it might be incompatible with iPad Devices which is odd?

yup your fully correct! I'll adjust the issue name to reflect the actual root cause

> Same, but it does work on iPhones. (I used **iPhone Layout** from YTLitePlus Settings) > > so I am assuming it might be incompatible with iPad Devices which is odd? yup your fully correct! I'll adjust the issue name to reflect the actual root cause

Macleykun commented 2024-06-15 20:53:26 +00:00 (Migrated from github.com)

Copy link

heyo, it's fixed in the latest commit, but how did you guys add this tweak into ytliteplus actually? through git submodules or?

heyo, it's fixed in the latest commit, but how did you guys add this tweak into ytliteplus actually? through git submodules or?

arichornlover commented 2024-06-15 20:56:21 +00:00 (Migrated from github.com)

Copy link

heyo, it's fixed in the latest commit

I don’t know what happened. I didn’t mess with it.

but how did you guys add this tweak into ytliteplus actually? through git submodules or?

YTLite 4.0.1 Deb

> heyo, it's fixed in the latest commit I don’t know what happened. I didn’t mess with it. > but how did you guys add this tweak into ytliteplus actually? through git submodules or? YTLite 4.0.1 Deb

Macleykun commented 2024-06-16 07:30:20 +00:00 (Migrated from github.com)

Copy link

heyo, it's fixed in the latest commit

I don’t know what happened. I didn’t mess with it.

but how did you guys add this tweak into ytliteplus actually? through git submodules or?

YTLite 4.0.1 Deb

Oh Nono I meant it’s fixed in the latest commit of that tweak! Not ytliteplus yet!
How can the Deb be updated to include in the latest yt native share?

> > heyo, it's fixed in the latest commit > > I don’t know what happened. I didn’t mess with it. > > > but how did you guys add this tweak into ytliteplus actually? through git submodules or? > > YTLite 4.0.1 Deb Oh Nono I meant it’s fixed in the latest commit of that tweak! Not ytliteplus yet! How can the Deb be updated to include in the latest yt native share?

arichornlover commented 2024-06-16 08:10:11 +00:00 (Migrated from github.com)

Copy link

Ohhh the GitHub repository of youtube-native-share updated. My bad 😅

Ohhh the GitHub repository of **youtube-native-share** updated. My bad 😅

Macleykun commented 2024-06-17 14:46:31 +00:00 (Migrated from github.com)

Copy link

@Balackburn
i noticed here: d9ccf7bad5/YTLitePlus.xm (L120)
that the native ios sharesheet can be used from the get go, sadly this doesn't seem to work for ipad.
But would it be possible to use this repo/commit to also use those hooks that the ipad uses? 8e3a6a98e8

@Balackburn i noticed here: https://github.com/YTLitePlus/YTLitePlus/blob/d9ccf7bad56bd47bc6ee86d4425f3be5a1b0d56f/YTLitePlus.xm#L120 that the native ios sharesheet can be used from the get go, sadly this doesn't seem to work for ipad. But would it be possible to use this repo/commit to also use those hooks that the ipad uses? https://github.com/jkhsjdhjs/youtube-native-share/commit/8e3a6a98e8d04106d50ac828f7e5530ac42e8350

Balackburn commented 2024-06-17 20:24:55 +00:00 (Migrated from github.com)

Copy link

@Macleykun Will look into it later when I have time.

@Macleykun Will look into it later when I have time.

arichornloverALT commented 2024-07-11 23:43:09 +00:00 (Migrated from github.com)

Copy link

@Macleykun Will look into it later when I have time.

Hey @Balackburn I fixed it today, I found out the problem and is fixed in v0.2.0!

> @Macleykun Will look into it later when I have time. Hey @Balackburn I fixed it today, I found out the problem and is fixed in v0.2.0!

❤️ 1

Macleykun commented 2024-07-12 07:03:38 +00:00 (Migrated from github.com)

Copy link

@Macleykun Will look into it later when I have time.

Here's the PR from arichornlover so you have all the info what you need to update the extension (if you don't use submodules for it) https://github.com/jkhsjdhjs/youtube-native-share/pull/3/files

> @Macleykun Will look into it later when I have time. Here's the PR from arichornlover so you have all the info what you need to update the extension (if you don't use submodules for it) https://github.com/jkhsjdhjs/youtube-native-share/pull/3/files

Macleykun commented 2024-07-15 19:49:47 +00:00 (Migrated from github.com)

Copy link

is it possible to re-open the issue meanwhile?

is it possible to re-open the issue meanwhile?

arichornloverALT commented 2024-07-15 20:23:16 +00:00 (Migrated from github.com)

Copy link

Sure. I reopened it, but here’s a sneak peak of what it will look like on iPad.

Sure. I reopened it, but here’s a sneak peak of what it will look like on iPad.   

Macleykun commented 2024-07-16 07:26:40 +00:00 (Migrated from github.com)

Copy link

Sure. I reopened it, but here’s a sneak peak of what it will look like on iPad.

Damn! That looks awsome! So much better then what google cooked up!

> Sure. I reopened it, but here’s a sneak peak of what it will look like on iPad.    Damn! That looks awsome! So much better then what google cooked up!

👍 1

bhackel commented 2024-08-10 13:10:05 +00:00 (Migrated from github.com)

Copy link

This seems to be fixed in latest versions. Going to close, we can reopen if issue persists. Thank you

This seems to be fixed in latest versions. Going to close, we can reopen if issue persists. Thank you

reticivis-net commented 2024-08-11 02:09:45 +00:00 (Migrated from github.com)

Copy link

It’s not fixed, I just downloaded a freshly cooked up ytliteplus ipa and I can’t share anything on iPad. The share sheet doesn’t even appear at all

It’s not fixed, I just downloaded a freshly cooked up ytliteplus ipa and I can’t share *anything* on iPad. The share sheet doesn’t even appear at all

bhackel commented 2024-08-11 02:14:00 +00:00 (Migrated from github.com)

Copy link

So there is no share interface showing with the Native Share off, and also no share interface when Native Share on?

So there is no share interface showing with the Native Share off, and also no share interface when Native Share on?

reticivis-net commented 2024-08-11 02:14:46 +00:00 (Migrated from github.com)

Copy link

Yep, lemme record a video

Yep, lemme record a video

reticivis-net commented 2024-08-11 02:19:38 +00:00 (Migrated from github.com)

Copy link

https://github.com/user-attachments/assets/17d5e0dd-96bb-49d8-9da6-9e6567ab6455

https://github.com/user-attachments/assets/17d5e0dd-96bb-49d8-9da6-9e6567ab6455

😕 1

bhackel commented 2024-08-15 06:20:03 +00:00 (Migrated from github.com)

Copy link

Waiting for a possible fix from version 5 of YTLite

Waiting for a possible fix from version 5 of YTLite

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

gesture-updates

dylib-building

YTLite5.0b

main-nightly

AppIcons

Makefile

gh-pages

v19.34.2-5.0.1

v19.32.6-4.0.1

v19.29.1-4.0.1

v19.23.3-4.0.1

v19.22.6-4.0.1

v19.21.3-4.0

v19.19.5-3.0.1

v19.18.2-3.0.1

v19.17.2-3.0.1

v19.16.3-3.0.1

v19.14.3-3.0.1

v19.12.3-3.0.1

v19.10.7-3.0.1

v19.10.5-3.0.1

v19.09.4-3.0.1

v19.09.3-3.0

v19.09.3-2.7

v19.08.2-2.7

v19.08.2-2.6.3

v19.07.4-2.6.1

v19.06.2-2.6.1

v19.06.2-2.6

v19.06.2-2.5

v19.06.2-2.4.1

v19.05.3-2.4.1

v19.04.3-2.4.1

v19.03.2-2.4.1

v19.03.2-2.4

v19.02.1-2.4

v19.01.1-2.4

v18.49.3-2.4

v18.48.3-2.4

v18.46.3-2.4

v18.45.2-2.4

v18.44.3-2.4

v18.41.2-2.3.1

v18.40.1-2.3.1

v18.39.1-2.3.1

v18.38.2-2.3.1

v18.35.4-2.3.1

v18.34.5-2.3.1

v18.33.3-2.3.1

v18.33.2-2.3.1

v18.32.2-2.3.1

v18.31.3-2.3.1

v18.30.6-2.3.1

v18.29.1-2.3.1

v18.29.1-2.3

v18.28.3-2.3

v18.27.3-2.3

v18.27.3-2.2.1

v18.25.1-2.2

v18.23.3-2.1

v18.25.1-2.1

v18.23.3-2.0

Labels

Clear labels   

YTLite

A bug related to YTLite

  

bug

Something isn't working

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

YTLite

bug

documentation

duplicate

enhancement

good first issue

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Creepso/YTLitePlus#165

No description provided.