Automatically get Youtube version from the ipa itself #100

Merged

Macleykun merged 13 commits from get-yt-ver into main

2024-03-18 10:27:35 +00:00

Macleykun commented

2024-03-18 10:12:44 +00:00

(Migrated from github.com)

Hello!

I finnaly figured out my unrelated issue to this PR! It seems that i had two seperate bugs which i'm not sure is ytliteplus or ytlite (definitly need to check with only ytlite if this is the case)

It seems that automatically disable subtitles in the player section of ytlite doesn't work if a video goes full screen automatically.
And if VP9 is turned on withoud proper entitlements it causes video's with multiple audio tracks (e.g. mr beast video's) to choose the second language of the list (in this case bulgarian or something between those lines). (Sounds more like a ytuhd thing but i also have to test that somehow seperatly to properly submit an issue on that).

ANYHOW! back to the PR!

I want to make one day some sort of ios shortcut that triggers that workflow with only giving the ipa url as an input, but i saw the yt version needs to be supplied each time, i figured that info should be stored in the ipa itself and found it so!

So instead of specifying it manually, it now does so automatically!
Proof:

I did this by checking this within the unpacked ipa file: main/tmp/Payload/YouTube.app/Info.plist (main/tmp/ is the location when using it in this workflow). From there the xml file has a key named CFBundleVersion and the string contains the value we ussually manually insert!

Do note the wiki needs to be slightly updated to reflect this change if you want to merge it, i did test this out and believe it's working as expected.

Hello! I finnaly figured out my unrelated issue to this PR! It seems that i had two seperate bugs which i'm not sure is ytliteplus or ytlite (definitly need to check with only ytlite if this is the case) It seems that automatically disable subtitles in the player section of ytlite doesn't work if a video goes full screen automatically. And if VP9 is turned on withoud proper entitlements it causes video's with multiple audio tracks (e.g. mr beast video's) to choose the second language of the list (in this case bulgarian or something between those lines). (Sounds more like a ytuhd thing but i also have to test that somehow seperatly to properly submit an issue on that). ANYHOW! back to the PR! I want to make one day some sort of ios shortcut that triggers that workflow with only giving the ipa url as an input, but i saw the yt version needs to be supplied each time, i figured that info should be stored in the ipa itself and found it so! So instead of specifying it manually, it now does so automatically! Proof: ![image](https://github.com/YTLitePlus/YTLitePlus/assets/26381427/762264e3-bdb2-45db-b209-2c72a6fbf3cc) I did this by checking this within the unpacked ipa file: main/tmp/Payload/YouTube.app/Info.plist (main/tmp/ is the location when using it in this workflow). From there the xml file has a key named CFBundleVersion and the string contains the value we ussually manually insert! Do note the wiki needs to be slightly updated to reflect this change if you want to merge it, i did test this out and believe it's working as expected.

Balackburn commented

2024-03-18 10:33:11 +00:00

(Migrated from github.com)

Thank you! I though about doing this but didn't, I think the same could be done with the YTLite version that can be extracted from /Tweaks/YTLite/Makefile PACKAGE_VERSION = X.X.X

It would then be completly automatic

Thank you! I though about doing this but didn't, I think the same could be done with the YTLite version that can be extracted from /Tweaks/YTLite/Makefile PACKAGE_VERSION = X.X.X It would then be completly automatic

Macleykun commented

2024-03-18 10:34:53 +00:00

(Migrated from github.com)

Thank you! I though about doing this but didn't, I think the same could be done with the YTLite version that can be extracted from /Tweaks/YTLite/Makefile PACKAGE_VERSION = X.X.X

It would then be completly automatic

oh i didn't realised that one, i'll have a look at it and make a pr for it :)

> Thank you! I though about doing this but didn't, I think the same could be done with the YTLite version that can be extracted from /Tweaks/YTLite/Makefile PACKAGE_VERSION = X.X.X > > It would then be completly automatic oh i didn't realised that one, i'll have a look at it and make a pr for it :)

👍 1