From e74b9d8c78c41f6d029e5d04a1a241f7d3d8d9cc Mon Sep 17 00:00:00 2001
From: cranci1 <100066266+cranci1@users.noreply.github.com>
Date: Mon, 27 Jan 2025 15:47:09 +0100
Subject: [PATCH] added duplicate module prevention

---
 Sora/Utils/Modules/ModuleManager.swift                   | 9 ++++++---
 .../SettingsSubViews/SettingsViewModule.swift            | 6 +++++-
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/Sora/Utils/Modules/ModuleManager.swift b/Sora/Utils/Modules/ModuleManager.swift
index 5c75fc6..9a2371e 100644
--- a/Sora/Utils/Modules/ModuleManager.swift
+++ b/Sora/Utils/Modules/ModuleManager.swift
@@ -42,6 +42,10 @@ class ModuleManager: ObservableObject {
             throw NSError(domain: "Invalid metadata URL", code: -1)
         }
         
+        if modules.contains(where: { $0.metadataUrl == metadataUrl }) {
+            throw NSError(domain: "Module already exists", code: -1)
+        }
+        
         let (metadataData, _) = try await URLSession.custom.data(from: url)
         let metadata = try JSONDecoder().decode(ModuleMetadata.self, from: metadataData)
         
@@ -72,7 +76,7 @@ class ModuleManager: ObservableObject {
         
         return module
     }
-
+    
     func deleteModule(_ module: ScrapingModule) {
         let localUrl = getDocumentsDirectory().appendingPathComponent(module.localPath)
         try? fileManager.removeItem(at: localUrl)
@@ -81,10 +85,9 @@ class ModuleManager: ObservableObject {
         saveModules()
         Logger.shared.log("Deleted module: \(module.metadata.sourceName)")
     }
-
+    
     func getModuleContent(_ module: ScrapingModule) throws -> String {
         let localUrl = getDocumentsDirectory().appendingPathComponent(module.localPath)
         return try String(contentsOf: localUrl, encoding: .utf8)
     }
 }
-
diff --git a/Sora/Views/SettingsView/SettingsSubViews/SettingsViewModule.swift b/Sora/Views/SettingsView/SettingsSubViews/SettingsViewModule.swift
index e21d053..da020b8 100644
--- a/Sora/Views/SettingsView/SettingsSubViews/SettingsViewModule.swift
+++ b/Sora/Views/SettingsView/SettingsSubViews/SettingsViewModule.swift
@@ -153,7 +153,11 @@ struct SettingsViewModule: View {
             } catch {
                 DispatchQueue.main.async {
                     isLoading = false
-                    errorMessage = "Failed to add module: \(error.localizedDescription)"
+                    if (error as NSError).domain == "Module already exists" {
+                        errorMessage = "Module already exists"
+                    } else {
+                        errorMessage = "Failed to add module: \(error.localizedDescription)"
+                    }
                     Logger.shared.log("Failed to add module: \(error.localizedDescription)")
                 }
             }