From 74c9a213302411ff9d70a8db87e55819c49369d1 Mon Sep 17 00:00:00 2001 From: codefactor-io Date: Wed, 1 Jan 2025 11:33:17 +0000 Subject: [PATCH] [CodeFactor] Apply fixes --- Sora/ContentView.swift | 2 +- .../Utils/CustomPlayer/Components/MusicProgressSlider.swift | 4 ++-- Sora/Utils/GitHub/GitHubAPI.swift | 2 +- Sora/Utils/Modules/ModulesManager.swift | 4 ++-- Sora/Views/HomeView.swift | 2 +- Sora/Views/MediaViews/EpisodesCell/EpisodeCell.swift | 2 +- Sora/Views/MediaViews/MediaExtraction.swift | 6 +++--- Sora/Views/MediaViews/MediaView.swift | 2 +- Sora/Views/SearchViews/SearchResultsView.swift | 2 +- 9 files changed, 13 insertions(+), 13 deletions(-) diff --git a/Sora/ContentView.swift b/Sora/ContentView.swift index 7ecbf4d..3cb1efd 100644 --- a/Sora/ContentView.swift +++ b/Sora/ContentView.swift @@ -53,7 +53,7 @@ struct ContentView: View { func fetchLatestRelease(completion: @escaping (GitHubRelease?) -> Void) { let url = URL(string: "https://api.github.com/repos/cranci1/Sora/releases/latest")! - URLSession.custom.dataTask(with: url) { data, response, error in + URLSession.custom.dataTask(with: url) { data, _, error in guard let data = data, error == nil else { completion(nil) return diff --git a/Sora/Utils/CustomPlayer/Components/MusicProgressSlider.swift b/Sora/Utils/CustomPlayer/Components/MusicProgressSlider.swift index 759b5c7..983996d 100644 --- a/Sora/Utils/CustomPlayer/Components/MusicProgressSlider.swift +++ b/Sora/Utils/CustomPlayer/Components/MusicProgressSlider.swift @@ -55,13 +55,13 @@ struct MusicProgressSlider: View { .frame(width: bounds.size.width, height: bounds.size.height, alignment: .center) .contentShape(Rectangle()) .gesture(DragGesture(minimumDistance: 0, coordinateSpace: .local) - .updating($isActive) { value, state, transaction in + .updating($isActive) { _, state, _ in state = true } .onChanged { gesture in localTempProgress = T(gesture.translation.width / bounds.size.width) value = max(min(getPrgValue(), inRange.upperBound), inRange.lowerBound) - }.onEnded { value in + }.onEnded { _ in localRealProgress = max(min(localRealProgress + localTempProgress, 1), 0) localTempProgress = 0 }) diff --git a/Sora/Utils/GitHub/GitHubAPI.swift b/Sora/Utils/GitHub/GitHubAPI.swift index 990cc5c..5dac7b5 100644 --- a/Sora/Utils/GitHub/GitHubAPI.swift +++ b/Sora/Utils/GitHub/GitHubAPI.swift @@ -25,7 +25,7 @@ class GitHubAPI { func fetchReleases(completion: @escaping ([GitHubReleases]?) -> Void) { let url = URL(string: "https://api.github.com/repos/cranci1/Sora/releases")! - URLSession.custom.dataTask(with: url) { data, response, error in + URLSession.custom.dataTask(with: url) { data, _, error in guard let data = data, error == nil else { completion(nil) return diff --git a/Sora/Utils/Modules/ModulesManager.swift b/Sora/Utils/Modules/ModulesManager.swift index 5965b0d..6013413 100644 --- a/Sora/Utils/Modules/ModulesManager.swift +++ b/Sora/Utils/Modules/ModulesManager.swift @@ -30,7 +30,7 @@ class ModulesManager: ObservableObject { completion(.failure(ModuleError.invalidURL)) return } - let task = URLSession.custom.dataTask(with: url) { data, response, error in + let task = URLSession.custom.dataTask(with: url) { data, _, error in guard let data = data, error == nil else { completion(.failure(error ?? ModuleError.unknown)) return @@ -69,7 +69,7 @@ class ModulesManager: ObservableObject { func refreshModules() { for (name, urlString) in moduleURLs { guard let url = URL(string: urlString) else { continue } - let task = URLSession.custom.dataTask(with: url) { data, response, error in + let task = URLSession.custom.dataTask(with: url) { data, _, error in guard let data = data, error == nil else { return } do { let updatedModule = try JSONDecoder().decode(ModuleStruct.self, from: data) diff --git a/Sora/Views/HomeView.swift b/Sora/Views/HomeView.swift index f596509..3af0df8 100644 --- a/Sora/Views/HomeView.swift +++ b/Sora/Views/HomeView.swift @@ -104,7 +104,7 @@ struct HomeView: View { return } - URLSession.custom.dataTask(with: url) { data, response, error in + URLSession.custom.dataTask(with: url) { data, _, error in guard let data = data, error == nil else { completion([]) return diff --git a/Sora/Views/MediaViews/EpisodesCell/EpisodeCell.swift b/Sora/Views/MediaViews/EpisodesCell/EpisodeCell.swift index ba1f0fb..ef61dce 100644 --- a/Sora/Views/MediaViews/EpisodesCell/EpisodeCell.swift +++ b/Sora/Views/MediaViews/EpisodesCell/EpisodeCell.swift @@ -66,7 +66,7 @@ struct EpisodeCell: View { return } - URLSession.custom.dataTask(with: url) { data, response, error in + URLSession.custom.dataTask(with: url) { data, _, error in if let error = error { print("Failed to fetch episode details: \(error)") DispatchQueue.main.async { diff --git a/Sora/Views/MediaViews/MediaExtraction.swift b/Sora/Views/MediaViews/MediaExtraction.swift index 1b60ec0..1f237a1 100644 --- a/Sora/Views/MediaViews/MediaExtraction.swift +++ b/Sora/Views/MediaViews/MediaExtraction.swift @@ -12,7 +12,7 @@ extension MediaView { func fetchItemDetails() { guard let url = URL(string: item.href.hasPrefix("https") ? item.href : "\(module.module[0].details.baseURL.hasSuffix("/") ? module.module[0].details.baseURL : "\(module.module[0].details.baseURL)/")\(item.href.hasPrefix("/") ? String(item.href.dropFirst()) : item.href)") else { return } - URLSession.custom.dataTask(with: url) { data, response, error in + URLSession.custom.dataTask(with: url) { data, _, error in defer { isLoading = false } guard let data = data, error == nil else { return } @@ -53,7 +53,7 @@ extension MediaView { guard let url = URL(string: urlString.hasPrefix("https") ? urlString : "\(module.module[0].details.baseURL)\(urlString)") else { return } Logger.shared.log("Pressed episode button") - URLSession.custom.dataTask(with: url) { data, response, error in + URLSession.custom.dataTask(with: url) { data, _, error in guard let data = data, error == nil else { return } let html = String(data: data, encoding: .utf8) ?? "" @@ -80,7 +80,7 @@ extension MediaView { let patternURL = extractPatternURL(from: html) guard let patternURL = patternURL else { return } - URLSession.custom.dataTask(with: patternURL) { data, response, error in + URLSession.custom.dataTask(with: patternURL) { data, _, error in guard let data = data, error == nil else { return } let patternHTML = String(data: data, encoding: .utf8) ?? "" diff --git a/Sora/Views/MediaViews/MediaView.swift b/Sora/Views/MediaViews/MediaView.swift index 9675766..71d84f6 100644 --- a/Sora/Views/MediaViews/MediaView.swift +++ b/Sora/Views/MediaViews/MediaView.swift @@ -352,7 +352,7 @@ struct MediaView: View { let parameters: [String: Any] = ["query": query] request.httpBody = try? JSONSerialization.data(withJSONObject: parameters) - URLSession.custom.dataTask(with: request) { data, response, error in + URLSession.custom.dataTask(with: request) { data, _, error in if let error = error { completion(.failure(error)) return diff --git a/Sora/Views/SearchViews/SearchResultsView.swift b/Sora/Views/SearchViews/SearchResultsView.swift index d1d0309..366497d 100644 --- a/Sora/Views/SearchViews/SearchResultsView.swift +++ b/Sora/Views/SearchViews/SearchResultsView.swift @@ -177,7 +177,7 @@ struct SearchResultsView: View { let urlString = "\(module.module[0].search.url)?\(module.module[0].search.parameter)=\(encodedSearchText)" guard let url = URL(string: urlString) else { return } - URLSession.custom.dataTask(with: url) { data, response, error in + URLSession.custom.dataTask(with: url) { data, _, error in defer { isLoading = false } guard let data = data, error == nil else { return }